v4.0.x: Add Missing MPI_F_XXX C constants #10530 #10533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Wootton <[email protected]> (cherry picked from commit f27c1de)
jjhursey
approved these changes
Jun 29, 2022
|
Was there a reason for the change in authorship of the 2nd commit on this PR? It's also confusing that there's 2 cherry-picked messages on that commit. |
|
I may have done something wrong in git processing since the cherry-pick did not run cleanly. |
Add some clarifying comments, update some stale comments, and fix some whitespace. No code or logic changes. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit d5f871d)
jjhursey
approved these changes
Jun 29, 2022
|
Looks like the wrong hash was grabbed (the v5 PR hash instead of the 'main' hash). It's all fixed up now. |
|
bot:aws:recheck |
jsquyres
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry pick of #10491 to include MPI Fortran constants used by C code in mpi.in.h for the v4.0.x branch.
This also includes commit d44ec62 for #10528
Signed-off-by: David Wootton [email protected]