common/ucx: Fix case where variable goes out of scope #10409
Conversation
|
Related PR #10365 MTT found a few cases ( The segv is caused by a NULL pointer being passed to a |
|
1 sec. I see another problem. Putting WIP on this. |
|
PR #10365 picked up a lock ( |
|
Should we maybe squash the commit since it's a critical commit for the initial commit? |
If a program makes the following call sequence: ``` MPI_T_init_thread MPI_T_finalize MPI_Init ``` Then a segv will occur in MPI_Init because the memory backing the `*opal_common_ucx.tls` will have been freed by the `mca_base_var_finalize` in `MPI_T_finalize`. But the 'opal_common_ucx.tls` will be valid. So add a check for this scenario so that we properly initialize the default string even in this case. * Add missing unlock Signed-off-by: Joshua Hursey <[email protected]>
|
Good idea. Squashed. |
If a program makes the following call sequence:
Then a segv will occur in MPI_Init because the memory backing the
*opal_common_ucx.tlswill have been freed by themca_base_var_finalizein
MPI_T_finalize. But the 'opal_common_ucx.tls` will be valid.So add a check for this scenario so that we properly initialize the
default string even in this case.
bot:notacherrypick