cm: fix selection priority #1039
Closed
+2
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes a priority check that disables cm if the previous pml had higher priority. The check was incorrect as coded and is unnecessary as we finalize all but one pml anyway. Fixes open-mpi#1035 Signed-off-by: Nathan Hjelm <[email protected]>
Closed
|
Per #1035 (comment), should the same check be made to ob1? |
This commit removes code that checks the ob1 priority vs the previous priority. The previous priority is meaningless here and may only cause ob1 to disable itself when it shouldn't. Signed-off-by: Nathan Hjelm <[email protected]>
|
@jsquyres Removed the ob1 check as well. I see no reason to disable any pml component in this manner. |
|
With this approach we don't need the field default_priority in the CM PLM. |
|
@yburette Does this fix your openib / PSM issue? |
|
@bosilca I will remove the default priority in CM completely in another commit. I want to have the mtl components set the priority of cm if a different manner. Should have the PR up soon. |
|
For history's sake here is the commit that added the extra selection checks: Since dr is dead I think it is safe to remove them. |
|
Will handle this all in #1040. |
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
…-barrier-bug v2.x: oshmem/scoll: Fix bug in basic/barrier algorithm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes a priority check that disables cm if the previous
pml had higher priority. The check was incorrect as coded and is
unnecessary as we finalize all but one pml anyway.
Fixes #1035
Signed-off-by: Nathan Hjelm [email protected]