common/ucx: fix variable registration memory leak and cleanup #10105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it may have been working because I am pretty sure we re-use the index even if we register, deregister, then register again. This, IIRC, is to ensure MPI_T does not break. Howard's fix worked fine but the leak introduced by the original code was still there. This can be considered a leak fix more than anything. |
hjelmn
force-pushed
the
the_words_fail_me_at_the_moment
branch
from
e3b0210 to
beb69e2
Compare
|
Something is odd with my checkout. I still saw the registered static variable in my version. I need to change the commit message. |
hjelmn
force-pushed
the
the_words_fail_me_at_the_moment
branch
from
beb69e2 to
15fadb6
Compare
hjelmn
changed the title
hjelmn
force-pushed
the
the_words_fail_me_at_the_moment
branch
from
15fadb6 to
e193d30
Compare
|
Ok, should be good to go. Not sure why my checkout was so old but @hoopoepg can verify. |
hjelmn
force-pushed
the
the_words_fail_me_at_the_moment
branch
from
e193d30 to
276e250
Compare
hoopoepg
reviewed
Mar 10, 2022
hoopoepg
approved these changes
Mar 10, 2022
The registration code in common/ucx was overly complex. It assumed that re-registration is not desireable when it essentially does the same as the find before the registration. The only thing that needs protection is resetting the char * variables before they are registered. The primary purpose of this commit to fix two memory leaks caused by the extra allocations to hold the strings. These allocations are unnecessary. Signed-off-by: Nathan Hjelm <[email protected]>
hjelmn
force-pushed
the
the_words_fail_me_at_the_moment
branch
from
276e250 to
5ad772c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registration code in common/ucx was overly complex. It assumed
that re-registration is not desireable when it essentially does the
same as the find before the registration. The only thing that needs
protection is resetting the char * variables before they are
registered.
The primary purpose of this commit to fix two memory leaks caused
by the extra allocations to hold the strings. These allocations
are unnecessary.
Signed-off-by: Nathan Hjelm [email protected]