Skip to content

checking if 8769 covers everything regarding partial datatypes #8818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markalle opened this issue Apr 14, 2021 · 5 comments
Closed

checking if 8769 covers everything regarding partial datatypes #8818

markalle opened this issue Apr 14, 2021 · 5 comments

Comments

@markalle
Copy link
Contributor

@bosilca recently made
#8769
and I'm not yet sure it's handling everything with the partial datatypes.

It's also possible I'm misusing the calls, so this is a bug report for continued investigation/discussion.

I made a testcase below that's based off the partial.c that George checked in. In unpacks 3 ints a few different ways and doesn't always get the right results.

Testcase: https://gist.github.com/markalle/eb0e67c5135c63c1ceac857de1ae3202

% cd test/datatype
% cp partial2.c partial.c
% rm -f partial
% make partial
% mpirun -np 1 ./partial
@jsquyres jsquyres changed the title checking if 8769 covers everything checking if 8769 covers everything regarding partial datatypes Apr 15, 2021
@markalle
Copy link
Contributor Author

Update: my first gist had a bug (at iov[0].iov_base = packed + length) and it works fine now with the pointer math there fixed to use (char*).

But the reason I was making that test is I wanted to test big-endian to make it do a conversion, so I've made that test here:
https://gist.github.com/markalle/ac88752093058857d98d7441a466e65b

Is the above expected to work?

@markalle
Copy link
Contributor Author

@bosilca Thoughts on this not appearing to work when the endianness is forcing conversions to be needed? Would opal_convertor_unpack() only be used in this partial-datatype + needing conversion method for messaging between heterogeneous ranks? If so then that wouldn't be real high priority for me. But I don't know if that's the context where the above path would happen

@gpaulsen
Copy link
Member

@markalle What should we do with this Issue? Can we close it, or is it a problem?

Copy link

It looks like this issue is expecting a response, but hasn't gotten one yet. If there are no responses in the next 2 weeks, we'll assume that the issue has been abandoned and will close it.

@github-actions github-actions bot added the Stale label Aug 29, 2024
Copy link

Per the above comment, it has been a month with no reply on this issue. It looks like this issue has been abandoned.

I'm going to close this issue. If I'm wrong and this issue is not abandoned, please feel free to re-open it. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants