-
Notifications
You must be signed in to change notification settings - Fork 901
Change configury logic to prefer external hwloc/libevent/pmix #5031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The bullets above were initially created from notes from the Dallas March 2018 meeting. Discussion welcome, especially before I start implementing. 😄 |
What is the rationale for using the internal version if external version At first glance, I would simply print a warning and use the external version. |
@ggouaillardet The thought there was that if the user didn't specify a preference, then we should just give them the latest version, regardless of whether it is internal or external. |
Per discussion on 2018-07-10 webex, for PMIx:
|
Note that the current status of master moved a few steps towards this scheme, but it also did a few things that are explicitly not in this scheme. For example, if the external component is configured successfully, it doesn't even try with the internal component -- which is contradictory to #5031 (comment): "The thought there was that if the user didn't specify a preference, then we should just give them the latest version, regardless of whether it is internal or external." So there is definitely still work to be done. |
IIRC, when the end user does not explicitly request anything, the external component version is tested, and is not selected if its version is lower than the embedded component. |
Can we close this issue now that PR #5472 has been merged to v4.0.x ? |
Based on Dallas March 2018 face-to-face meeting notes, we want to shift the focus in v4.0.x away from the embedded hwloc, libevent, and pmix to external versions of these libraries.
Specifically, change the configury logic:
configure
>=
the internal version, use the external version.<
the internal version, emit a warning and use the internal version.Also add relevant
ompi_info
output somewhere indicating whether we are using internal or external versions, and give the reason why.The text was updated successfully, but these errors were encountered: