Skip to content

Commit 94400d9

Browse files
authored
Merge pull request #4356 from jsquyres/pr/v2.x/dont-allow-hwloc-external-ge-2-0
v2.x: hwloc/external: abort if hwloc v2 is detected since it is not yet sup…
2 parents d32b0fa + 289ad8e commit 94400d9

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

README

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1078,6 +1078,10 @@ MISCELLANEOUS SUPPORT LIBRARIES
10781078
to include Open MPI and use their default hwloc installation instead
10791079
of Open MPI's bundled hwloc.
10801080

1081+
Note that this version of Open MPI does not support hwloc >= v2.0.
1082+
If hwloc v2.0.x support is needed, Open MPI v3.1.x (and later) can
1083+
be used.
1084+
10811085
hwloc is a support library that provides processor and memory
10821086
affinity information for NUMA platforms.
10831087

opal/mca/hwloc/external/configure.m4

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,22 @@ AC_DEFUN([MCA_opal_hwloc_external_CONFIG],[
176176
[AC_MSG_RESULT([yes])],
177177
[AC_MSG_RESULT([no])
178178
AC_MSG_ERROR([Cannot continue])])
179+
AC_MSG_CHECKING([if external hwloc version is lower than 2.0])
180+
AS_IF([test "$opal_hwloc_dir" != ""],
181+
[opal_hwloc_external_CFLAGS_save=$CFLAGS
182+
CFLAGS="-I$opal_hwloc_dir/include $opal_hwloc_external_CFLAGS_save"])
183+
AC_COMPILE_IFELSE(
184+
[AC_LANG_PROGRAM([[#include <hwloc.h>]],
185+
[[
186+
#if HWLOC_API_VERSION >= 0x00020000
187+
#error "hwloc API version is greater or equal than 0x00020000"
188+
#endif
189+
]])],
190+
[AC_MSG_RESULT([yes])],
191+
[AC_MSG_RESULT([no])
192+
AC_MSG_ERROR([The Open MPI v2.1.x series does not support hwloc >= v2.0.
193+
Open MPI v3.1.0 and later support hwloc >= v2.0.
194+
Cannot continue])])
179195
AS_IF([test "$opal_hwloc_dir" != ""],
180196
[CFLAGS=$opal_hwloc_external_CFLAGS_save])
181197

0 commit comments

Comments
 (0)