This change fixes the misleading error message from mpiexec wtih missing #! interpreter (#4528). I added a conditional to check whether the file exists, which determines whether to ouput the default error string (missing file) or a new string (bad interpreter).

Signed-off-by: Maxwell Coil <[email protected]>

Author: mcoil1

orte/mca/odls/default/odls_default_module.c

@@ -454,10 +454,17 @@ static int do_child(orte_odls_spawn_caddy_t *cd, int write_fd)
 
     /* Exec the new executable */
     execve(cd->cmd, cd->argv, cd->env);
+    struct stat stats;
     getcwd(dir, sizeof(dir));
-    send_error_show_help(write_fd, 1,
+    if(0 == stat(cd->app->app, &stats)) {
+        send_error_show_help(write_fd, 1, "help-orte-odls-default.txt",
+                         "execve error", orte_process_info.nodename, dir,
+                         cd->app->app, "Bad interpreter");
+    } else {
+        send_error_show_help(write_fd, 1,
                          "help-orte-odls-default.txt", "execve error",
                          orte_process_info.nodename, dir, cd->app->app, strerror(errno));
+    }
     /* Does not return */
 }