PML/UCX: fixed ucp request free on persistent request completion

Sergey Oblomov · Sergey Oblomov · commit 6fe0a73861b5 · 2018-07-20T19:32:20.000+03:00
- in sine cases persistent request was deleted during completion
  callback, this cause double free of linked UCX request (assert
  in debug build or hang in release build)
- UCX request is freed prior completion calback

Signed-off-by: Sergey Oblomov &lt;sergeyo@mellanox.com&gt;
diff --git a/ompi/mca/pml/ucx/pml_ucx_request.c b/ompi/mca/pml/ucx/pml_ucx_request.c
@@ -85,10 +85,10 @@ mca_pml_ucx_persistent_request_complete(mca_pml_ucx_persistent_request_t *preq,
                                         ompi_request_t *tmp_req)
 {
     preq->ompi.req_status = tmp_req->req_status;
-    ompi_request_complete(&preq->ompi, true);
-    mca_pml_ucx_persistent_request_detach(preq, tmp_req);
     mca_pml_ucx_request_reset(tmp_req);
+    mca_pml_ucx_persistent_request_detach(preq, tmp_req);
     ucp_request_free(tmp_req);
+    ompi_request_complete(&preq->ompi, true);
 }
 
 static inline void mca_pml_ucx_preq_completion(ompi_request_t *tmp_req)

Original file line number	Diff line number	Diff line change
`@@ -85,10 +85,10 @@ mca_pml_ucx_persistent_request_complete(mca_pml_ucx_persistent_request_t *preq,`
`85`	`85`	`ompi_request_t *tmp_req)`
`86`	`86`	`{`
`87`	`87`	`preq->ompi.req_status = tmp_req->req_status;`
`88`		`- ompi_request_complete(&preq->ompi, true);`
`89`		`- mca_pml_ucx_persistent_request_detach(preq, tmp_req);`
`90`	`88`	`mca_pml_ucx_request_reset(tmp_req);`
	`89`	`+ mca_pml_ucx_persistent_request_detach(preq, tmp_req);`
`91`	`90`	`ucp_request_free(tmp_req);`
	`91`	`+ ompi_request_complete(&preq->ompi, true);`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`static inline void mca_pml_ucx_preq_completion(ompi_request_t *tmp_req)`