Fix iquote check for different C and Fotran preprocessors

 * Some C and Fortran compilers use different preprocessors. If one preprocessor
   accepts `-iquote` and the other does not then a compiler error will occur
   when Open MPI tries to use it.
   - Nvidia/PGI v22.1-0 is one such. The C compiler supports `-iquote`
     while the Fortran compiler does not.
 * Strengthen the `-iquote` check to check both compilers before
   deciding to use `-iquote`. If one or both does not support it then
   fallback to `-I`.

Signed-off-by: Joshua Hursey <[email protected]>

Author: jjhursey

config/opal_setup_cc.m4

@@ -18,7 +18,7 @@ dnl Copyright (c) 2015-2019 Research Organization for Information Science
 dnl                         and Technology (RIST).  All rights reserved.
 dnl Copyright (c) 2020      Triad National Security, LLC. All rights
 dnl                         reserved.
-dnl Copyright (c) 2021      IBM Corporation.  All rights reserved.
+dnl Copyright (c) 2021-2022 IBM Corporation.  All rights reserved.
 dnl
 dnl $COPYRIGHT$
 dnl
@@ -129,17 +129,41 @@ AC_DEFUN([OPAL_PROG_CC_C11],[
 # which added a <version> header. This conflicts with the
 # VERSION file at the base of our source directory on case-
 # insensitive filesystems.
+#
+# Note that some C and Fortran use different preprocessors (nvidia/pgi 22.1-0,
+# for example). So it is not sufficient to check just a C program, but also
+# a Fortran program in this routine. Since '-I' is the most widely supported
+# that is our default if one or both of the preprocessors does not support
+# '-iquote'.
 AC_DEFUN([OPAL_CHECK_CC_IQUOTE],[
     OPAL_VAR_SCOPE_PUSH([opal_check_cc_iquote_CFLAGS_save])
     opal_check_cc_iquote_CFLAGS_save=${CFLAGS}
-    CFLAGS="${CFLAGS} -iquote ."
+
     AC_MSG_CHECKING([for $CC option to add a directory only to the search path for the quote form of include])
+    CFLAGS="${CFLAGS} -iquote."
+    AC_LANG_PUSH(C)
     AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]],[])],
 		      [opal_cc_iquote="-iquote"],
 		      [opal_cc_iquote="-I"])
+    AC_MSG_RESULT([\"$opal_cc_iquote\"])
+    AC_LANG_POP(C)
     CFLAGS=${opal_check_cc_iquote_CFLAGS_save}
+
+    # Double check against Fortran preprocessor (unless Fortran support is disabled)
+    AS_IF([test "$opal_cc_iquote" != "-I" -a $OMPI_TRY_FORTRAN_BINDINGS != $OMPI_FORTRAN_NO_BINDINGS],
+          [AC_MSG_CHECKING([for $FC option to see if it also supports -iquote form of include])
+           AC_LANG_PUSH(Fortran)
+           opal_check_cc_iquote_FCFLAGS_save=${FCFLAGS}
+           FCFLAGS="${FCFLAGS} -iquote."
+           AC_COMPILE_IFELSE([AC_LANG_PROGRAM([],[])],
+		             [AC_MSG_RESULT([Yes. \"$opal_cc_iquote\" accepted]) ],
+		             [opal_cc_iquote="-I"
+                              AC_MSG_RESULT([No. \"$opal_cc_iquote\" will be used instead]) ])
+           AC_LANG_POP(Fortran)
+           FCFLAGS=${opal_check_cc_iquote_FCFLAGS_save}
+           ])
+
     OPAL_VAR_SCOPE_POP
-    AC_MSG_RESULT([$opal_cc_iquote])
 ])
 
 # OPAL_SETUP_CC()