Skip to content

Commit 3fcb88a

Browse files
committed
Merge pull request #646 from edgargabriel/pr/non-blocking-coll
Pr/non blocking coll
2 parents 5d38283 + dedeee9 commit 3fcb88a

33 files changed

+294
-796
lines changed

ompi/mca/fcoll/dynamic/Makefile.am

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# University of Stuttgart. All rights reserved.
1010
# Copyright (c) 2004-2005 The Regents of the University of California.
1111
# All rights reserved.
12-
# Copyright (c) 2008-2011 University of Houston. All rights reserved.
12+
# Copyright (c) 2008-2015 University of Houston. All rights reserved.
1313
# Copyright (c) 2012 Cisco Systems, Inc. All rights reserved.
1414
# $COPYRIGHT$
1515
#
@@ -23,11 +23,7 @@ sources = \
2323
fcoll_dynamic_module.c \
2424
fcoll_dynamic_component.c \
2525
fcoll_dynamic_file_read_all.c \
26-
fcoll_dynamic_file_read_all_begin.c \
27-
fcoll_dynamic_file_read_all_end.c \
28-
fcoll_dynamic_file_write_all.c \
29-
fcoll_dynamic_file_write_all_begin.c \
30-
fcoll_dynamic_file_write_all_end.c
26+
fcoll_dynamic_file_write_all.c
3127

3228
# Make the output library in this directory, and name it either
3329
# mca_<type>_<name>.la (for DSO builds) or libmca_<type>_<name>.la

ompi/mca/fcoll/dynamic/fcoll_dynamic.h

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -54,29 +54,13 @@ int mca_fcoll_dynamic_file_read_all (mca_io_ompio_file_t *fh,
5454
struct ompi_datatype_t *datatype,
5555
ompi_status_public_t * status);
5656

57-
int mca_fcoll_dynamic_file_read_all_begin (mca_io_ompio_file_t *fh,
58-
void *buf,
59-
int count,
60-
struct ompi_datatype_t *datatype);
61-
62-
int mca_fcoll_dynamic_file_read_all_end (mca_io_ompio_file_t *fh,
63-
void *buf,
64-
ompi_status_public_t * status);
6557

6658
int mca_fcoll_dynamic_file_write_all (mca_io_ompio_file_t *fh,
6759
void *buf,
6860
int count,
6961
struct ompi_datatype_t *datatype,
7062
ompi_status_public_t * status);
7163

72-
int mca_fcoll_dynamic_file_write_all_begin (mca_io_ompio_file_t *fh,
73-
void *buf,
74-
int count,
75-
struct ompi_datatype_t *datatype);
76-
77-
int mca_fcoll_dynamic_file_write_all_end (mca_io_ompio_file_t *fh,
78-
void *buf,
79-
ompi_status_public_t * status);
8064

8165
END_C_DECLS
8266

ompi/mca/fcoll/dynamic/fcoll_dynamic_file_read_all_begin.c

Lines changed: 0 additions & 36 deletions
This file was deleted.

ompi/mca/fcoll/dynamic/fcoll_dynamic_file_read_all_end.c

Lines changed: 0 additions & 35 deletions
This file was deleted.

ompi/mca/fcoll/dynamic/fcoll_dynamic_file_write_all_begin.c

Lines changed: 0 additions & 36 deletions
This file was deleted.

ompi/mca/fcoll/dynamic/fcoll_dynamic_file_write_all_end.c

Lines changed: 0 additions & 35 deletions
This file was deleted.

ompi/mca/fcoll/dynamic/fcoll_dynamic_module.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
* University of Stuttgart. All rights reserved.
1010
* Copyright (c) 2004-2005 The Regents of the University of California.
1111
* All rights reserved.
12-
* Copyright (c) 2008-2011 University of Houston. All rights reserved.
12+
* Copyright (c) 2008-2015 University of Houston. All rights reserved.
1313
* $COPYRIGHT$
1414
*
1515
* Additional copyrights may follow
@@ -36,11 +36,11 @@ static mca_fcoll_base_module_1_0_0_t dynamic = {
3636
mca_fcoll_dynamic_module_init,
3737
mca_fcoll_dynamic_module_finalize,
3838
mca_fcoll_dynamic_file_read_all,
39-
mca_fcoll_dynamic_file_read_all_begin,
40-
mca_fcoll_dynamic_file_read_all_end,
39+
NULL, /* iread_all */
4140
mca_fcoll_dynamic_file_write_all,
42-
mca_fcoll_dynamic_file_write_all_begin,
43-
mca_fcoll_dynamic_file_write_all_end
41+
NULL, /*iwrite_all */
42+
NULL, /* progress */
43+
NULL /* request_free */
4444
};
4545

4646
int

ompi/mca/fcoll/fcoll.h

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
* University of Stuttgart. All rights reserved.
1111
* Copyright (c) 2004-2005 The Regents of the University of California.
1212
* All rights reserved.
13-
* Copyright (c) 2008-2011 University of Houston. All rights reserved.
13+
* Copyright (c) 2008-2015 University of Houston. All rights reserved.
1414
* Copyright (c) 2015 Los Alamos National Security, LLC. All rights
1515
* reserved.
1616
* $COPYRIGHT$
@@ -27,10 +27,12 @@
2727
#include "mpi.h"
2828
#include "ompi/mca/mca.h"
2929
#include "opal/mca/base/base.h"
30+
#include "ompi/request/request.h"
3031

3132
BEGIN_C_DECLS
3233

3334
struct mca_io_ompio_file_t;
35+
struct mca_fcoll_request_t;
3436

3537
/*
3638
* Macro for use in components that are of type coll
@@ -115,16 +117,12 @@ typedef int (*mca_fcoll_base_module_file_read_all_fn_t)
115117
struct ompi_datatype_t *datatype,
116118
ompi_status_public_t *status);
117119

118-
typedef int (*mca_fcoll_base_module_file_read_all_begin_fn_t)
120+
typedef int (*mca_fcoll_base_module_file_iread_all_fn_t)
119121
(struct mca_io_ompio_file_t *fh,
120122
void *buf,
121123
int count,
122-
struct ompi_datatype_t *datatype);
123-
124-
typedef int (*mca_fcoll_base_module_file_read_all_end_fn_t)
125-
(struct mca_io_ompio_file_t *fh,
126-
void *buf,
127-
ompi_status_public_t *status);
124+
struct ompi_datatype_t *datatype,
125+
ompi_request_t **request);
128126

129127
typedef int (*mca_fcoll_base_module_file_write_all_fn_t)
130128
(struct mca_io_ompio_file_t *fh,
@@ -133,16 +131,18 @@ typedef int (*mca_fcoll_base_module_file_write_all_fn_t)
133131
struct ompi_datatype_t *datatype,
134132
ompi_status_public_t *status);
135133

136-
typedef int (*mca_fcoll_base_module_file_write_all_begin_fn_t)
134+
typedef int (*mca_fcoll_base_module_file_iwrite_all_fn_t)
137135
(struct mca_io_ompio_file_t *fh,
138136
void *buf,
139137
int count,
140-
struct ompi_datatype_t *datatype);
138+
struct ompi_datatype_t *datatype,
139+
ompi_request_t **request);
141140

142-
typedef int (*mca_fcoll_base_module_file_write_all_end_fn_t)
143-
(struct mca_io_ompio_file_t *fh,
144-
void *buf,
145-
ompi_status_public_t *status);
141+
typedef bool (*mca_fcoll_base_module_progress_fn_t)
142+
( struct mca_fcoll_request_t *request);
143+
144+
typedef void (*mca_fcoll_base_module_request_free_fn_t)
145+
( struct mca_fcoll_request_t *request);
146146

147147
/*
148148
* ***********************************************************************
@@ -160,11 +160,12 @@ struct mca_fcoll_base_module_1_0_0_t {
160160

161161
/* FCOLL function pointers */
162162
mca_fcoll_base_module_file_read_all_fn_t fcoll_file_read_all;
163-
mca_fcoll_base_module_file_read_all_begin_fn_t fcoll_file_read_all_begin;
164-
mca_fcoll_base_module_file_read_all_end_fn_t fcoll_file_read_all_end;
163+
mca_fcoll_base_module_file_iread_all_fn_t fcoll_file_iread_all;
165164
mca_fcoll_base_module_file_write_all_fn_t fcoll_file_write_all;
166-
mca_fcoll_base_module_file_write_all_begin_fn_t fcoll_file_write_all_begin;
167-
mca_fcoll_base_module_file_write_all_end_fn_t fcoll_file_write_all_end;
165+
mca_fcoll_base_module_file_iwrite_all_fn_t fcoll_file_iwrite_all;
166+
mca_fcoll_base_module_progress_fn_t fcoll_progress;
167+
mca_fcoll_base_module_request_free_fn_t fcoll_request_free;
168+
168169
};
169170
typedef struct mca_fcoll_base_module_1_0_0_t mca_fcoll_base_module_1_0_0_t;
170171
typedef mca_fcoll_base_module_1_0_0_t mca_fcoll_base_module_t;

ompi/mca/fcoll/individual/Makefile.am

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# University of Stuttgart. All rights reserved.
1010
# Copyright (c) 2004-2005 The Regents of the University of California.
1111
# All rights reserved.
12-
# Copyright (c) 2008-2011 University of Houston. All rights reserved.
12+
# Copyright (c) 2008-2015 University of Houston. All rights reserved.
1313
# Copyright (c) 2012 Cisco Systems, Inc. All rights reserved.
1414
# $COPYRIGHT$
1515
#
@@ -23,11 +23,7 @@ sources = \
2323
fcoll_individual_module.c \
2424
fcoll_individual_component.c \
2525
fcoll_individual_file_read_all.c \
26-
fcoll_individual_file_read_all_begin.c \
27-
fcoll_individual_file_read_all_end.c \
28-
fcoll_individual_file_write_all.c \
29-
fcoll_individual_file_write_all_begin.c \
30-
fcoll_individual_file_write_all_end.c
26+
fcoll_individual_file_write_all.c
3127

3228
# Make the output library in this directory, and name it either
3329
# mca_<type>_<name>.la (for DSO builds) or libmca_<type>_<name>.la

ompi/mca/fcoll/individual/fcoll_individual.h

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -54,29 +54,13 @@ int mca_fcoll_individual_file_read_all (mca_io_ompio_file_t *fh,
5454
struct ompi_datatype_t *datatype,
5555
ompi_status_public_t * status);
5656

57-
int mca_fcoll_individual_file_read_all_begin (mca_io_ompio_file_t *fh,
58-
void *buf,
59-
int count,
60-
struct ompi_datatype_t *datatype);
61-
62-
int mca_fcoll_individual_file_read_all_end (mca_io_ompio_file_t *fh,
63-
void *buf,
64-
ompi_status_public_t * status);
6557

6658
int mca_fcoll_individual_file_write_all (mca_io_ompio_file_t *fh,
6759
void *buf,
6860
int count,
6961
struct ompi_datatype_t *datatype,
7062
ompi_status_public_t * status);
7163

72-
int mca_fcoll_individual_file_write_all_begin (mca_io_ompio_file_t *fh,
73-
void *buf,
74-
int count,
75-
struct ompi_datatype_t *datatype);
76-
77-
int mca_fcoll_individual_file_write_all_end (mca_io_ompio_file_t *fh,
78-
void *buf,
79-
ompi_status_public_t * status);
8064

8165
END_C_DECLS
8266

ompi/mca/fcoll/individual/fcoll_individual_file_read_all_begin.c

Lines changed: 0 additions & 36 deletions
This file was deleted.

0 commit comments

Comments
 (0)