opal/datatype: fix opal_convertor_raw

correctly handle the case in which iovec is full and the
last accessed element of the datatype is the beginning of a loop

Refs. #6285

Thanks Axel Huebl for reporting this

Signed-off-by: Gilles Gouaillardet <[email protected]>

Author: ggouaillardet

opal/datatype/opal_convertor_raw.c

@@ -5,7 +5,7 @@
  *                         reserved.
  * Copyright (c) 2009      Oak Ridge National Labs.  All rights reserved.
  * Copyright (c) 2013      Cisco Systems, Inc.  All rights reserved.
- * Copyright (c) 2017-2018 Research Organization for Information Science
+ * Copyright (c) 2017-2019 Research Organization for Information Science
  *                         and Technology (RIST).  All rights reserved.
  * $COPYRIGHT$
  *
@@ -170,8 +170,18 @@ opal_convertor_raw( opal_convertor_t* pConvertor,
             ddt_endloop_desc_t* end_loop = (ddt_endloop_desc_t*)(pElem + pElem->loop.items);
 
             if( pElem->loop.common.flags & OPAL_DATATYPE_FLAG_CONTIGUOUS ) {
-                source_base += end_loop->first_elem_disp;
-                for(size_t i = count_desc; (i > 0) && (index < *iov_count); i--, index++ ) {
+                ptrdiff_t offset = end_loop->first_elem_disp;
+                source_base += offset;
+                for(size_t i = count_desc; i > 0; i--, index++ ) {
+                    if (index >= *iov_count) {
+                        dt_elem_desc_t* nElem = pElem + 1;
+                        while (nElem->elem.common.type == OPAL_DATATYPE_LOOP) {
+                            nElem++;
+                        }
+                        assert(OPAL_DATATYPE_END_LOOP != nElem->elem.common.type);
+                        offset = nElem->elem.disp;
+                        break;
+                    }
                     OPAL_DATATYPE_SAFEGUARD_POINTER( source_base, end_loop->size, pConvertor->pBaseBuf,
                                                 pConvertor->pDesc, pConvertor->count );
                     iov[index].iov_base = (IOVBASE_TYPE *) source_base;
@@ -180,7 +190,7 @@ opal_convertor_raw( opal_convertor_t* pConvertor,
                     raw_data += end_loop->size;
                     count_desc--;
                 }
-                source_base -= end_loop->first_elem_disp;
+                source_base -= offset;
                 if( 0 == count_desc ) {  /* completed */
                     pos_desc += pElem->loop.items + 1;
                     goto update_loop_description;

test/datatype/Makefile.am

@@ -4,8 +4,8 @@
 #                         reserved.
 # Copyright (c) 2006-2015 Cisco Systems, Inc.  All rights reserved.
 # Copyright (c) 2009      Oak Ridge National Labs.  All rights reserved.
-# Copyright (c) 2014-2015 Research Organization for Information Science
-#                         and Technology (RIST). All rights reserved.
+# Copyright (c) 2014-2019 Research Organization for Information Science
+#                         and Technology (RIST).  All rights reserved.
 # Copyright (c) 2016      IBM Corporation.  All rights reserved.
 # $COPYRIGHT$
 #
@@ -15,7 +15,7 @@
 #
 
 if PROJECT_OMPI
-    MPI_TESTS = checksum position position_noncontig ddt_test ddt_raw unpack_ooo ddt_pack external32 large_data
+    MPI_TESTS = checksum position position_noncontig ddt_test ddt_raw ddt_raw2 unpack_ooo ddt_pack external32 large_data
     MPI_CHECKS = to_self
 endif
 TESTS = opal_datatype_test unpack_hetero $(MPI_TESTS)
@@ -40,6 +40,12 @@ ddt_raw_LDADD = \
         $(top_builddir)/ompi/lib@[email protected] \
         $(top_builddir)/opal/lib@[email protected]
 
+ddt_raw2_SOURCES = ddt_raw2.c ddt_lib.c ddt_lib.h
+ddt_raw2_LDFLAGS = $(OMPI_PKG_CONFIG_LDFLAGS)
+ddt_raw2_LDADD = \
+        $(top_builddir)/ompi/lib@[email protected] \
+        $(top_builddir)/opal/lib@[email protected]
+
 ddt_pack_SOURCES = ddt_pack.c
 ddt_pack_LDFLAGS = $(OMPI_PKG_CONFIG_LDFLAGS)
 ddt_pack_LDADD = \