Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

coll/base: fix memory allocation in mca_coll_base_alltoall_intra_basi… #687

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ompi/mca/coll/basic/coll_basic_alltoall.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ mca_coll_basic_alltoall_intra_inplace(void *rbuf, int rcount,
MPI_Request *preq;
char *tmp_buffer;
size_t max_size;
ptrdiff_t ext;
ptrdiff_t ext, true_lb, true_ext;

/* Initialize. */

Expand All @@ -57,13 +57,15 @@ mca_coll_basic_alltoall_intra_inplace(void *rbuf, int rcount,

/* Find the largest receive amount */
ompi_datatype_type_extent (rdtype, &ext);
max_size = ext * rcount;
ompi_datatype_get_true_extent ( rdtype, &true_lb, &true_ext);
max_size = true_ext + ext * (rcount-1);

/* Allocate a temporary buffer */
tmp_buffer = calloc (max_size, 1);
if (NULL == tmp_buffer) {
return OMPI_ERR_OUT_OF_RESOURCE;
}
max_size = ext * rcount;

/* in-place alltoall slow algorithm (but works) */
for (i = 0 ; i < size ; ++i) {
Expand Down