This repository was archived by the owner on Sep 30, 2022. It is now read-only.
v2.x: oshmem: get rid of oshmem_proc_t and use ompi_proc_t instead #1358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
store oshmem related per proc data in an oshmem_proc_data_t struct, that is stored in the padding section of an ompi_proc_t this data can be accessed via the OSHMEM_PROC_DATA(proc) macro Fixes open-mpi/ompi#2023 (back-ported from commit open-mpi/ompi@0a25420)
|
:bot:assign: @jsquyres |
|
OMPIBot error: Label "code-cleanup" does not exist. |
|
:bot🏷️Code-cleanup-low-priority |
|
Test PASSed. |
|
@ggouaillardet This should probably be assigned to someone in Mellanox to review, no? @jladd-mlnx @artpol84 @alex-mikheev @igor-ivanov @miked-mellanox |
|
Fair enough @igor-ivanov could you please review this PR ? :bot:unassign: @jsquyres |
|
👍 |
|
@jsquyres this looks good to go |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store oshmem related per proc data in an oshmem_proc_data_t struct,
that is stored in the padding section of an ompi_proc_t
this data can be accessed via the OSHMEM_PROC_DATA(proc) macro
Fixes open-mpi/ompi#2023
(back-ported from commit open-mpi/ompi@0a25420)