Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

v2.x: libnbc fixes #1355

Merged
merged 2 commits into from
Sep 12, 2016
Merged

Conversation

ggouaillardet
Copy link
Contributor

Fixes open-mpi/ompi#2034

  • fix NBC_Copy for predefined but non contiguous datatypes such as MPI_LONG_DOUBLE_INT
  • fix nbc_ireduce when sendbuf == recvbuf on non root ranks

Thanks Valentin Petrov for the report

predefined datatypes such as MPI_LONG_DOUBLE_INT are not really contiguous,
so use span as returned by opal_datatype_span() instead of type extent,
otherwise data might be written above allocated memory.

Thanks Valentin Petrov for the report

(cherry picked from commit open-mpi/ompi@2969235)
if sendbuf is equal to recvbuf, that should not be interpreted
as equivalent to MPI_IN_PLACE on the non root rank(s)

Thanks Valentin Petrov for the report

(cherry picked from commit open-mpi/ompi@75b7ef9)
@ggouaillardet
Copy link
Contributor Author

:bot:assign: @bosilca
:bot:milestone:v2.0.1
:bot🏷️bug
:bot🏷️blocker

@hppritcha this fixes the bug reported at open-mpi/ompi#2034
ideally, i'd like to have it fixed in v2.0.1

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/2145/ for details.

@jsquyres jsquyres modified the milestones: v2.0.2, v2.0.1 Sep 1, 2016
@jsquyres
Copy link
Member

jsquyres commented Sep 1, 2016

Deferred to v2.0.2.

@jsquyres jsquyres removed the blocker label Sep 1, 2016
@ggouaillardet
Copy link
Contributor Author

note @bosilca already reviewed #1356 which is basically the same PR, but for the v1.10 series

@bosilca
Copy link
Member

bosilca commented Sep 2, 2016

👍

@jsquyres
Copy link
Member

@hppritcha Good to go

@hppritcha hppritcha merged commit 8b28d01 into open-mpi:v2.x Sep 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault int MPI_Ireduce with libnbc
6 participants