This repository was archived by the owner on Sep 30, 2022. It is now read-only.
v2.0.2: compiler warnings stomp #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2016 04:51
…get max_procs as required. (cherry picked from commit open-mpi/ompi@08022d7)
(cherry picked from commit open-mpi/ompi@6549c87)
|
Test PASSed. |
|
No, you don't need the pmix changes in here - @jjhursey has those in another PR. They won't harm anything, but won't contribute anything either. 👍 on the rest |
|
@hppritcha Let's wait for the @jjhursey PR to come in first. Then I'll de-tangle what's left. |
|
I believe the few compiler fixes you are waiting on are in PR #1354 - which is ready to go. |
|
#1354 is now merged; this one is good to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some compiler warnings that were already done on master, but didn't come over to v2.x.
Master commits are noted in individual commit messages.
@rhc54 Are the pmix fixes necessary? These were lumped into warnings fixes commits. 😦