Skip to content

[Enhancement] Clear UT warning caused by pytest #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 22, 2023

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented Feb 21, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Clear UT warning caused by pytest. More details at https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose

image

scikit-learn/scikit-learn#22572

Modification

Replace setup(self) with setup_method(self) and teardown(self) with teardown_method(self).

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@b14c179). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 5d04a88 differs from pull request most recent head 7cd2f4a. Consider uploading reports for the commit 7cd2f4a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #947   +/-   ##
=======================================
  Coverage        ?   76.64%           
=======================================
  Files           ?      138           
  Lines           ?    10816           
  Branches        ?     2163           
=======================================
  Hits            ?     8290           
  Misses          ?     2170           
  Partials        ?      356           
Flag Coverage Δ
unittests 76.64% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhouzaida zhouzaida merged commit c94e751 into open-mmlab:main Feb 22, 2023
@zhouzaida zhouzaida deleted the clear-ut-warning branch February 22, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant