feat!: Use strings from spec for error and reason enums #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-feature#123 Signed-off-by: Alexandre Chakroun <[email protected]>
beeme1mr
approved these changes
Apr 30, 2024
josecolella
approved these changes
Apr 30, 2024
beeme1mr
changed the title
alxckn
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 99.48% 99.48%
=======================================
Files 15 15
Lines 195 196 +1
=======================================
+ Hits 194 195 +1
Misses 1 1 ☔ View full report in Codecov by Sentry. |
maxveldink
approved these changes
May 1, 2024
Contributor
maxveldink
left a comment
maxveldink
left a comment
There was a problem hiding this comment.
Thanks for the contribution! First one to the primary SDK I believe 🎉
Technically, this is a breaking change if someone is relying on those backing strings, so we'll want to name this feat!: ... for a breaking change.
beeme1mr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123
Upper cases error and reason enum values and adds missing 'PROVIDER_FATAL' error