fix: fix status handlers running immediately if provider already in associated state

Signed-off-by: Federico Bond <[email protected]>

Author: federicobond

openfeature/api.py

@@ -39,7 +39,8 @@ def set_provider(
 
 
 def clear_providers() -> None:
-    return _provider_registry.clear_providers()
+    _provider_registry.clear_providers()
+    _event_support.clear()
 
 
 def get_provider_metadata(domain: typing.Optional[str] = None) -> Metadata:

openfeature/event.py

@@ -6,7 +6,7 @@
 from typing import TYPE_CHECKING, Callable, Dict, List, Optional, Union
 
 from openfeature.exception import ErrorCode
-from openfeature.provider import FeatureProvider
+from openfeature.provider import FeatureProvider, ProviderStatus
 
 if TYPE_CHECKING:
     from openfeature.client import OpenFeatureClient
@@ -16,9 +16,18 @@ class ProviderEvent(Enum):
     PROVIDER_READY = "PROVIDER_READY"
     PROVIDER_CONFIGURATION_CHANGED = "PROVIDER_CONFIGURATION_CHANGED"
     PROVIDER_ERROR = "PROVIDER_ERROR"
+    PROVIDER_FATAL = "PROVIDER_FATAL"
     PROVIDER_STALE = "PROVIDER_STALE"
 
 
+_provider_status_to_event = {
+    ProviderStatus.READY: ProviderEvent.PROVIDER_READY,
+    ProviderStatus.ERROR: ProviderEvent.PROVIDER_ERROR,
+    ProviderStatus.FATAL: ProviderEvent.PROVIDER_FATAL,
+    ProviderStatus.STALE: ProviderEvent.PROVIDER_STALE,
+}
+
+
 @dataclass
 class ProviderEventDetails:
     flags_changed: Optional[List[str]] = None
@@ -114,6 +123,9 @@ def run_handlers_for_provider(
     def _run_immediate_handler(
         self, client: OpenFeatureClient, event: ProviderEvent, handler: EventHandler
     ) -> None:
-        if event == ProviderEvent.PROVIDER_READY:
-            # providers are assumed ready because provider status is not yet implemented
+        if event == _provider_status_to_event.get(client.get_provider_status()):
             handler(EventDetails(provider_name=client.provider.get_metadata().name))
+
+    def clear(self) -> None:
+        self._global_handlers.clear()
+        self._client_handlers.clear()

openfeature/provider/registry.py

@@ -1,6 +1,10 @@
 import typing
 
 from openfeature.evaluation_context import EvaluationContext
+from openfeature.event import (
+    ProviderEventDetails,
+    _provider_status_to_event,
+)
 from openfeature.exception import ErrorCode, GeneralError, OpenFeatureError
 from openfeature.provider import FeatureProvider, ProviderStatus
 from openfeature.provider.no_op_provider import NoOpProvider
@@ -14,8 +18,9 @@ class ProviderRegistry:
     def __init__(self) -> None:
         self._default_provider = NoOpProvider()
         self._providers = {}
-        self._provider_status = {}
-        self._set_provider_status(self._default_provider, ProviderStatus.NOT_READY)
+        self._provider_status = {
+            self._default_provider: ProviderStatus.READY,
+        }
 
     def set_provider(self, domain: str, provider: FeatureProvider) -> None:
         if provider is None:
@@ -50,6 +55,9 @@ def clear_providers(self) -> None:
         self.shutdown()
         self._providers.clear()
         self._default_provider = NoOpProvider()
+        self._provider_status = {
+            self._default_provider: ProviderStatus.READY,
+        }
 
     def shutdown(self) -> None:
         for provider in {self._default_provider, *self._providers.values()}:
@@ -90,3 +98,8 @@ def _set_provider_status(
         self, provider: FeatureProvider, status: ProviderStatus
     ) -> None:
         self._provider_status[provider] = status
+
+        if event := _provider_status_to_event.get(status):
+            from openfeature.api import _run_handlers_for_provider
+
+            _run_handlers_for_provider(provider, event, ProviderEventDetails())

tests/conftest.py

@@ -5,13 +5,12 @@
 
 
 @pytest.fixture(autouse=True)
-def clear_provider():
+def clear_providers():
     """
     For tests that use set_provider(), we need to clear the provider to avoid issues
     in other tests.
     """
-    yield
-    _provider = None
+    api.clear_providers()
 
 
 @pytest.fixture()