Skip to content

Commit 041d431

Browse files
committed
feature/provider-metadata: Test extending metadata class
Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
1 parent 1a72156 commit 041d431

File tree

4 files changed

+21
-1
lines changed

4 files changed

+21
-1
lines changed

open_feature/flag_evaluation/hooks.py

Whitespace-only changes.
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
from dataclasses import dataclass
2+
3+
from open_feature.provider.metadata import Metadata
4+
5+
6+
@dataclass
7+
class NoOpMetadata(Metadata):
8+
name: str = "No-op Provider"
9+
is_test_class: bool = True

open_feature/provider/no_op_provider.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,15 @@
44
from open_feature.flag_evaluation.flag_evaluation_details import FlagEvaluationDetails
55
from open_feature.flag_evaluation.reason import Reason
66
from open_feature.provider.metadata import Metadata
7+
from open_feature.provider.no_op_metadata import NoOpMetadata
78
from open_feature.provider.provider import AbstractProvider
89

910
PASSED_IN_DEFAULT = "Passed in default"
1011

1112

1213
class NoOpProvider(AbstractProvider):
1314
def get_metadata(self) -> Metadata:
14-
return Metadata(name="No-op Provider")
15+
return NoOpMetadata()
1516

1617
def get_boolean_details(
1718
self,

tests/provider/test_no_op_provider.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,16 @@ def setup():
1010
assert isinstance(provider, NoOpProvider)
1111

1212

13+
def test_should_return_no_op_provider_metadata(no_op_provider_client):
14+
# Given
15+
# When
16+
metadata = NoOpProvider().get_metadata()
17+
# Then
18+
assert metadata is not None
19+
assert metadata.name == "No-op Provider"
20+
assert metadata.is_test_class
21+
22+
1323
def test_should_get_boolean_flag_from_no_op(no_op_provider_client):
1424
# Given
1525
# When

0 commit comments

Comments
 (0)