add more unit tests

Signed-off-by: odubajDT <[email protected]>

Author: odubajDT

webhooks/common_test.go

@@ -178,3 +178,13 @@ func Test_NewFeatureFlagSourceSpec(t *testing.T) {
 
 	require.Equal(t, expected, NewFeatureFlagSourceSpec(env))
 }
+
+func Test_shouldUseRPC(t *testing.T) {
+	require.True(t, shouldUseRPC(map[string]string{
+		fmt.Sprintf("%s/%s", common.OpenFeatureAnnotationPrefix, common.FeatureFlagSourceAnnotation): "value",
+	}))
+
+	require.False(t, shouldUseRPC(map[string]string{
+		fmt.Sprintf("%s/%s", common.OpenFeatureAnnotationPrefix, common.FeatureFlagInProcessSourceAnnotation): "value",
+	}))
+}

webhooks/pod_webhook_test.go

@@ -29,9 +29,10 @@ import (
 )
 
 const (
-	mutatePodNamespace           = "test-mutate-pod"
-	defaultPodServiceAccountName = "test-pod-service-account"
-	featureFlagSourceName        = "test-feature-flag-source"
+	mutatePodNamespace             = "test-mutate-pod"
+	defaultPodServiceAccountName   = "test-pod-service-account"
+	featureFlagSourceName          = "test-feature-flag-source"
+	featureFlagInProcessSourceName = "test-feature-flag-in-process-source"
 )
 
 func TestPodMutator_BackfillPermissions(t *testing.T) {
@@ -258,6 +259,22 @@ func TestPodMutator_Handle(t *testing.T) {
 	goodAnnotatedPod, err := json.Marshal(antPod)
 	require.Nil(t, err)
 
+	inProcessPod := corev1.Pod{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "myAnnotatedPod",
+			Namespace: mutatePodNamespace,
+			Annotations: map[string]string{
+				fmt.Sprintf("%s/%s", common.OpenFeatureAnnotationPrefix, common.EnabledAnnotation):                    "true",
+				fmt.Sprintf("%s/%s", common.OpenFeatureAnnotationPrefix, common.FeatureFlagInProcessSourceAnnotation): fmt.Sprintf("%s/%s", mutatePodNamespace, featureFlagInProcessSourceName),
+			},
+			OwnerReferences: []metav1.OwnerReference{{UID: "123"}},
+		},
+		Spec: corev1.PodSpec{ServiceAccountName: defaultPodServiceAccountName},
+	}
+
+	goodInProcessAnnotatedPod, err := json.Marshal(inProcessPod)
+	require.Nil(t, err)
+
 	tests := []struct {
 		name     string
 		mutator  *PodMutator
@@ -402,7 +419,7 @@ func TestPodMutator_Handle(t *testing.T) {
 			wantCode: http.StatusNotFound,
 		},
 		{
-			name: "happy path: request pod annotated configured for env var",
+			name: "happy path rpc: request pod annotated configured for env var",
 			mutator: &PodMutator{
 				Client: NewClient(true,
 					&antPod,
@@ -448,6 +465,64 @@ func TestPodMutator_Handle(t *testing.T) {
 			},
 			allow: true,
 		},
+		{
+			name: "happy path in-process: request pod annotated configured for env var",
+			mutator: &PodMutator{
+				Client: NewClient(true,
+					&inProcessPod,
+					&corev1.ServiceAccount{
+						ObjectMeta: metav1.ObjectMeta{
+							Name:      defaultPodServiceAccountName,
+							Namespace: mutatePodNamespace,
+						},
+					},
+					&rbac.ClusterRoleBinding{
+						ObjectMeta: metav1.ObjectMeta{Name: common.ClusterRoleBindingName},
+						Subjects:   nil,
+						RoleRef:    rbac.RoleRef{},
+					},
+					&api.FeatureFlagInProcessSource{
+						ObjectMeta: metav1.ObjectMeta{
+							Name:      featureFlagInProcessSourceName,
+							Namespace: mutatePodNamespace,
+						},
+						Spec: api.FeatureFlagInProcessSourceSpec{
+							EnvVars: []corev1.EnvVar{
+								{
+									Name:  "env1",
+									Value: "val1",
+								},
+								{
+									Name:  "env2",
+									Value: "val2",
+								},
+							},
+						},
+					},
+				),
+				decoder: decoder,
+				Log:     testr.New(t),
+			},
+			req: admission.Request{
+				AdmissionRequest: admissionv1.AdmissionRequest{
+					UID: "123",
+					Object: runtime.RawExtension{
+						Raw:    goodInProcessAnnotatedPod,
+						Object: &inProcessPod,
+					},
+				},
+			},
+			setup: func(mockInjector *flagdinjectorfake.MockFlagdContainerInjector) {
+				mockInjector.EXPECT().
+					InjectFlagd(
+						gomock.Any(),
+						gomock.Any(),
+						gomock.Any(),
+						gomock.Any(),
+					).Return(nil).Times(0)
+			},
+			allow: true,
+		},
 		{
 			name: "wrong request",
 			mutator: &PodMutator{