chore: fix lint issues and bump server sdk version #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeme1mr
changed the title
toddbaert
approved these changes
Jan 3, 2024
Member
toddbaert
left a comment
toddbaert
left a comment
There was a problem hiding this comment.
Approved, but there's a couple more lint issues you can fix if you want. Some might be easy to fix, for those that are not I would suggest you ignore them.
Kavindu-Dodan
approved these changes
Jan 3, 2024
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
force-pushed
the
fix-lint-issues
branch
from
89fcff0 to
4351b55
Compare
Member
Author
|
@toddbaert fixed. |
thomaspoignant
approved these changes
Jan 4, 2024
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Notes
These issues were showing up in the "Unchanged files with check annotations" section of other PRs.