feat: support metadata in errors in OFREP #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
commented
Feb 5, 2025
beeme1mr
reviewed
Feb 5, 2025
toddbaert
force-pushed
the
feat/ofrep-metadata
branch
from
66fe4f0 to
8a2a9c3
Compare
toddbaert
changed the title
toddbaert
commented
Feb 6, 2025
toddbaert
commented
Feb 6, 2025
toddbaert
commented
Feb 6, 2025
toddbaert
force-pushed
the
feat/ofrep-metadata
branch
from
8a2a9c3 to
3ed58d6
Compare
toddbaert
commented
Feb 6, 2025
toddbaert
commented
Feb 6, 2025
toddbaert
commented
Feb 6, 2025
toddbaert
force-pushed
the
feat/ofrep-metadata
branch
from
3ed58d6 to
e033170
Compare
beeme1mr
reviewed
Feb 6, 2025
beeme1mr
reviewed
Feb 7, 2025
toddbaert
force-pushed
the
feat/ofrep-metadata
branch
from
3ef0d71 to
b520c12
Compare
beeme1mr
reviewed
Feb 7, 2025
toddbaert
force-pushed
the
feat/ofrep-metadata
branch
2 times, most recently
from
a356f3a to
04b7488
Compare
beeme1mr
approved these changes
Feb 7, 2025
toddbaert
force-pushed
the
feat/ofrep-metadata
branch
2 times, most recently
from
b9ac7e1 to
3558d0d
Compare
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/ofrep-metadata
branch
from
3558d0d to
b0de3b2
Compare
beeme1mr
approved these changes
Feb 13, 2025
Signed-off-by: Todd Baert <[email protected]>
lukas-reining
approved these changes
Feb 13, 2025
Member
lukas-reining
left a comment
lukas-reining
left a comment
There was a problem hiding this comment.
Looks good to me! Left nits only.
| try { | ||
| const result = await this.ofrepApi.postEvaluateFlag(flagKey, { context }); | ||
| return this.toResolutionDetails(result, defaultValue); | ||
| return this.responseToResolutionDetails(result, defaultValue); |
Member
There was a problem hiding this comment.
Why the change? I find the name a bit confusing.
I would argue that toResolutionDetails matches good.
| export type EvaluationFlagValue = FlagValue; | ||
|
|
||
| export interface EvaluationSuccessResponse { | ||
| export interface MetadataResponse { |
Member
There was a problem hiding this comment.
Nit: I would not expect this to have the Response suffix, rather something like EvaluationResponseMetadata, but it might also be a foreign language problem for me :D
This was referenced Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.