fix: use isEmpty and not equals

thomaspoignant · toddbaert · commit c6fa1fd2652a · 2024-07-02T10:27:42.000-04:00
Signed-off-by: Thomas Poignant &lt;thomas.poignant@gofeatureflag.org&gt;
diff --git a/providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/controller/GoFeatureFlagController.java b/providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/controller/GoFeatureFlagController.java
@@ -142,7 +142,7 @@ public <T> EvaluationResponse<T> evaluateFlag(
                             requestMapper.writeValueAsBytes(goffRequest),
                             MediaType.get("application/json; charset=utf-8")));
 
-            if (this.apiKey != null && !"".equals(this.apiKey)) {
+            if (this.apiKey != null && !this.apiKey.isEmpty()) {
                 reqBuilder.addHeader(HttpHeaders.AUTHORIZATION, BEARER_TOKEN + this.apiKey);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ public <T> EvaluationResponse<T> evaluateFlag(`
`142`	`142`	`requestMapper.writeValueAsBytes(goffRequest),`
`143`	`143`	`MediaType.get("application/json; charset=utf-8")));`
`144`	`144`
`145`		`- if (this.apiKey != null && !"".equals(this.apiKey)) {`
	`145`	`+ if (this.apiKey != null && !this.apiKey.isEmpty()) {`
`146`	`146`	`reqBuilder.addHeader(HttpHeaders.AUTHORIZATION, BEARER_TOKEN + this.apiKey);`
`147`	`147`	`}`
`148`	`148`