Mirror intel/llvm commits #2763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes issue intel/llvm#18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored. Also fixes up an artifact in the UR command-buffer spec where it says that descriptors to the command-buffer creation API can be optional, when after intel/llvm#17058 they are mandatory.
We no longer need to create a UR sampler object in order to create a sampled image. The backends can simply use the sampler description to create the sampled image. Note this is an ABI break in the currently still experimental bindless images extension for Unified Runtime. Addresses the following issue: #1463 Relevant discussion from #2640 (comment) Additionally, avoiding the allocation of a sampler object itself fixes memory leak(s) in all adapters where the UR sampler handle was never released which was caused by the use of the API in the SYCL RT only calling urSamplerCreate and not Release for the sampler associated with the image. Also, while HIP and Cuda do not further create backend specific sampler objects in the respective adapters, Level Zero was creating one that never got released upon freeing the image memory which lead to leaking the Level Zero sampler memory as well. Now that Level Zero can create a sampled image from a descriptor only, the sampler object is not needed altogether, allowing to rid of the above mentioned leaking memory allocations and simplify the runtime.
Signed-off-by: Neil R. Spruit <[email protected]>
This reapplies some of the changes from intel/llvm#17536 (without changes to leak_checker which broke internal testing). This fixes: intel/llvm#18463
github-actions
bot
added
ci/cd
Unified Runtime -> intel/llvm Repo Move NoticeInformationThe source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime. The contribution guide will be updated with new instructions for contributing to Unified Runtime. PR MigrationAll open PRs including this one will be marked with the Should you wish to continue with your PR you will need to migrate it to intel/llvm. If your PR should remain open and not be closed automatically, you can remove the This is an automated comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action