[DeviceSanitizer] When link with libc++, link the gcc_s first. #2478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingcong-wu
requested review from
zhaomaosu,
AllanZyne and
jinge90
and removed request for
a team
AllanZyne
reviewed
Dec 19, 2024
AllanZyne
approved these changes
Dec 19, 2024
zhaomaosu
approved these changes
Dec 23, 2024
|
Hi @unified-runtime-maintain, please help review this PR. |
|
A more proper way to eliminate this problem is to build a standalone dynamic lib for the symbolizer. I am working on that. |
kbenzie
approved these changes
Jan 6, 2025
|
Changes pulled in by intel/llvm#16478. |
kbenzie
added a commit
that referenced
this pull request
Jan 7, 2025
[DeviceSanitizer] When link with libc++, link the gcc_s first.
kbenzie
added a commit
that referenced
this pull request
Jan 7, 2025
[DeviceSanitizer] When link with libc++, link the gcc_s first.
kbenzie
added a commit
that referenced
this pull request
Jan 8, 2025
[DeviceSanitizer] When link with libc++, link the gcc_s first.
kbenzie
added a commit
that referenced
this pull request
Jan 8, 2025
[DeviceSanitizer] When link with libc++, link the gcc_s first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to static link the libc++, some namespace-less/common symbols got resolved to libc++/libc++abi/libunwind first before it got a chance to resolve to libstdc++ and related libs. This causes a stdlib mismatch problem and leads to one device sanitizer test(options-invalid-values.cpp) SEGV when trying to throw an exception.
By putting
gcc_sfirst, we can prevent such a problem.intel/llvm PR: intel/llvm#16525