[IMP] snippets: preserve same file module #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aj-fuentes
reviewed
Jul 9, 2025
cawo-odoo
force-pushed
the
master-imp_make_pickleable_callback_preserve_same_file-cawo
branch
2 times, most recently
from
55085dc to
1e7abe7
Compare
|
If we intend to reuse this in other scripts I'd move it to |
aj-fuentes
reviewed
Jul 11, 2025
cawo-odoo
force-pushed
the
master-imp_make_pickleable_callback_preserve_same_file-cawo
branch
2 times, most recently
from
cc1dcba to
214126f
Compare
cawo-odoo
commented
Jul 11, 2025
cawo-odoo
force-pushed
the
master-imp_make_pickleable_callback_preserve_same_file-cawo
branch
2 times, most recently
from
874c7e4 to
5c41b91
Compare
KangOl
reviewed
Jul 11, 2025
In `make_pickleable_callback`, when creating a name for the module created via import_script, no longer make the name random, but derive it from the script's path deterministically via a hash function. This way, when this method is called multiple times from the same script for multiple callbacks, it will only import the script once and otherwise re-use the created module. This ensures multiple callbacks from the same script file will run within the same module, seeing e.g. the same values in modified globals, which is much more intuitive. Also, move the function to `misc.py`. With the intention to reuse it, it's a better fit. For that, make it python2 compatible.
cawo-odoo
force-pushed
the
master-imp_make_pickleable_callback_preserve_same_file-cawo
branch
from
5c41b91 to
3d69959
Compare
|
upgradeci retry with always only website documents mrp spreadsheet_editions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
make_pickleable_callback, when creating a name for the module created via import_script, no longer make the name random, but derive it from the script's path deterministically via a hash function. This way, when this method is called multiple times from the same script for multiple callbacks, it will only import the script once and otherwise re-use the created module. This ensures multiple callbacks from the same script file will run within the same module, seeing e.g. the same values in modified globals, which is much more intuitive.Also, move the function to
misc.py. With the intention to reuse it, it's a better fit. For that, make it python2 compatible.