[IMP] estate: Implemented offer acceptance and refusal actions;

 Implemented offer acceptance and refusal actions;
added state management buttons in property views

[FIX] estate: resolve Runbot style and linting errors (Ruff/Semgrep)

This commit fixes all Runbot Check Style issues for the estate module.

[FIX] estate: Cleaned up code by removing unnecessary blank lines in model files

Author: hapat-odoo

Estate/__init__.py

@@ -1,2 +1 @@
 from . import models
-

Estate/models/__init__.py

@@ -2,4 +2,3 @@
 from . import estate_property_offer
 from . import estate_property_type
 from . import estate_property_tag
-

Estate/models/estate_property.py

@@ -1,5 +1,4 @@
-
-from odoo import models, fields , api 
+from odoo import models, fields, api
 from datetime import timedelta
 
 
@@ -10,7 +9,7 @@ class EstateProperty(models.Model):
     name = fields.Char(required=True)
     description = fields.Text()
     postcode = fields.Char()
-    create_date = fields.Date()
+    create_date = fields.Datetime()
     expected_price = fields.Float(required=True)
     selling_price = fields.Float()
     bedrooms = fields.Integer()
@@ -20,66 +19,90 @@ class EstateProperty(models.Model):
     garden = fields.Boolean()
     garden_area = fields.Integer()
     garden_orientation = fields.Selection([
-        ('north', 'North'),
-        ('south', 'South'),
-        ('east', 'East'),
-        ('west', 'West'),
+        ("north", "North"),
+        ("south", "South"),
+        ("east", "East"),
+        ("west", "West"),
     ])
-    state = fields.Selection(
-        [
-            ('new', 'New'),
-            ('offer_received', 'Offer Received'),
-            ('offer_accepted', 'Offer Accepted'),
-            ('sold', 'Sold'),
-            ('canceled', 'Canceled'),
-        ],
-        string="Status",
-        required=True,
-        copy=False,
-        default='new'
-    )
     active = fields.Boolean(default=True)
-    property_type_id = fields.Many2one("estate.property.type", string="Property Type")        
+
+    state = fields.Selection([
+        ("new", "New"),
+        ("offer_received", "Offer Received"),
+        ("offer_accepted", "Offer Accepted"),
+        ("sold", "Sold"),
+        ("canceled", "Canceled"),
+    ], string="Status", required=True, copy=False, default="new")
+
+    property_type_id = fields.Many2one("estate.property.type", string="Property Type")
     buyer_id = fields.Many2one("res.partner", string="Buyer")
     salesperson_id = fields.Many2one("res.users", string="Salesperson")
     tag_ids = fields.Many2many("estate.property.tag", string="Tags")
     offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
+
     total_area = fields.Float(compute="_compute_total_area", string="Total Area", store=True)
     best_price = fields.Float(compute="_compute_best_price", string="Best Offer", store=True)
-    validity_days = fields.Integer(default=7)
-    deadline_date = fields.Date(compute="_compute_validity_date", string="Validity Date", store=True)
-    @api.depends('living_area', 'garden_area')
+
+    validity = fields.Integer(default=7)
+    date_deadline = fields.Date(
+        compute="_compute_date_deadline",
+        inverse="_inverse_date_deadline",
+        store=True,
+    )
+
+    @api.depends("living_area", "garden_area")
     def _compute_total_area(self):
         for record in self:
-            record.total_area = record.living_area + (record.garden_area or 0)  
-    @api.depends('offer_ids.price')
+            record.total_area = (record.living_area or 0) + (record.garden_area or 0)
+
+    @api.depends("offer_ids.price")
     def _compute_best_price(self):
         for record in self:
-            if record.offer_ids:
-                record.best_price = max(record.offer_ids.mapped('price'))
-            else:
-                record.best_price = 0.0
-    
-    @api.depends('create_date', 'validity_days')
-    def _compute_validity_date(self):
-        if  self.create_date:
-            for record in self:
-                record.deadline_date = record.create_date + timedelta(days=record.validity_days)
-        else:
-            for record in self:
-                record.deadline_date = fields.Date.today() + timedelta(days=record.validity_days)   
-
-    @api.onchange('garden_area')
-    def  _onchange_garden(self):   
+            record.best_price = max(record.offer_ids.mapped("price")) if record.offer_ids else 0.0
+
+    @api.depends("create_date", "validity")
+    def _compute_date_deadline(self):
         for record in self:
-            if self.garden_area == 10:
-                self.garden_orientation = 'north'
-            if self.garden_area == 20:  
-                self.garden_orientation = 'south'
-            if self.garden_area == 30:
-                self.garden_orientation = 'east'
-            if self.garden_area == 40:
-                self.garden_orientation = 'west'
+            create_date = record.create_date or fields.Date.today()
+            if hasattr(create_date, "date"):
+                create_date = create_date.date()
+            record.date_deadline = create_date + timedelta(days=record.validity)
+
+    def _inverse_date_deadline(self):
+        for record in self:
+            create_date = record.create_date or fields.Date.today()
+            if hasattr(create_date, "date"):
+                create_date = create_date.date()
+            delta = (record.date_deadline - create_date).days if record.date_deadline else 0
+            record.validity = delta
+
+    @api.onchange("garden")
+    def _onchange_garden(self):
+        for record in self:
+            if record.garden:
+                record.garden_area = 10
+                record.garden_orientation = "north"
             else:
-                self.garden_area = 0
-                self.garden_orientation = False
+                record.garden_area = 0
+                record.garden_orientation = False
+
+    def action_set_sold(self):
+        for record in self:
+            record.state = "sold"
+
+    def action_set_canceled(self):
+        for record in self:
+            record.state = "canceled"
+
+    def action_set_next_status(self):
+        for record in self:
+            if record.state == "new":
+                record.state = "offer_received"
+            elif record.state == "offer_received":
+                record.state = "offer_accepted"
+            elif record.state == "offer_accepted":
+                record.state = "sold"
+
+    def action_back_to_new(self):
+        for record in self:
+            record.state = "new"

Estate/models/estate_property_offer.py

@@ -1,5 +1,6 @@
 from odoo import models, fields
 
+
 class EstatePropertyOffer(models.Model):
     _name = "estate.property.offer"
     _description = "Real Estate Property Offer"
@@ -11,6 +12,14 @@ class EstatePropertyOffer(models.Model):
             ('refused', 'Refused'),
         ],
     )
-    
+
     property_id = fields.Many2one("estate.property", string="Property", required=True)
     partner_id = fields.Many2one("res.partner", string="Buyer", required=True)
+
+    def action_accept_offer(self):
+        for record in self:
+            record.status = 'accepted'
+
+    def action_refuse_offer(self):
+        for record in self:
+            record.status = 'refused'

Estate/models/estate_property_tag.py

@@ -1,7 +1,8 @@
 from odoo import models, fields
 
+
 class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
     _description = "Real Estate Property Tag"
 
-    name = fields.Char(required=True)
+    name = fields.Char(required=True)

Estate/models/estate_property_type.py

@@ -1,7 +1,8 @@
 from odoo import models, fields
 
+
 class EstatePropertyType(models.Model):
     _name = "estate.property.type"
     _description = "Real Estate Property Type"
 
-    name = fields.Char(required=True)
+    name = fields.Char(required=True)

Estate/views/estate_property_offer_views.xml

@@ -6,6 +6,8 @@
             <list>
                 <field name="price" />
                 <field name="partner_id" />
+                <button name="action_accept_offer" string="Accept" type="object" />
+                <button name="action_refuse_offer" string="Refuse" type="object" />
                 <field name="status" />
             </list>
         </field>
@@ -20,6 +22,8 @@
                     <group>
                         <field name="price"/>
                         <field name="partner_id"/>
+                        <button name="action_accept_offer" string="Accept" type="object" />
+                        <button name="action_refuse_offer" string="Refuse" type="object" />
                         <field name="status"/>
                     </group>
                 </sheet>

Estate/views/estate_property_views.xml

@@ -39,6 +39,13 @@
                 <h1>
                     <field name="name" placeholder="Property Name"/>
                 </h1>
+                <header>
+                    <button name="action_set_next_status" string="Next" type="object"/>
+                    <button name="action_back_to_new" string="Reset to New" type="object"/>
+                    <button name="action_set_sold" string="Mark as Sold" type="object"/>
+                    <button name="action_set_canceled" string="Cancel" type="object"/>
+                    <field name="state" widget="statusbar" statusbar_visible="new,offer_received,offer_accepted,sold,canceled"/>
+                </header>
                 <group col="2">
                     <group string="Property Details">
                         <field name="postcode"/>
@@ -78,6 +85,8 @@
                             <list editable="bottom">
                                 <field name="partner_id"/>
                                 <field name="price"/>
+                                <button name="action_accept_offer" string="Accept" type="object" />
+                                <button name="action_refuse_offer" string="Refuse" type="object" />
                                 <field name="status"/>
                             </list>
                         </field>