Skip to content

[IMP] accounting: (multi) companies, branches & accountant access info #13474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

afma-odoo
Copy link
Contributor

task-3645172

@robodoo
Copy link
Collaborator

robodoo commented May 21, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team May 21, 2025 09:35
@afma-odoo afma-odoo requested review from a team and removed request for a team May 21, 2025 09:37
@afma-odoo afma-odoo force-pushed the 17.0-accounting-branch-management-afma branch from d1dfdf2 to 03542c5 Compare May 22, 2025 11:13
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @afma-odoo, thanks a lot for tackling this task! I left a few comments and suggestions. Overall:

  • I suggested reworking how some of the information is presented, and changing the page structure a bit to avoid repeated content and improve clarity (see my individual comments on this).
  • I suggest using parent company instead of main company throughout the doc to avoid confusion. “Main company” can be ambiguous and might even be misinterpreted (e.g., as “default company”?)
  • Update the Kenyan loca where branch management is mentioned a lot: we could add some references or links to this doc page and change "main company" into "parent company" where appropriate. --> we can do this in a separate PR if you prefer!
  • I’d rename the anchors in the companies.rst file to include the fiel name (i.e., general/companies/xxx)

Thank you for your work and let me know if you want to discuss any of my suggestions/comments!

Comment on lines +155 to +172
Access rights
-------------

Branches also have a :guilabel:`Parent Company` set on the branch form in :ref:`developer mode
<developer-mode>`. Accounting and fiscal localizations for the branch are set on the
:guilabel:`Parent Company`. To do so, select the company from the *company selector* in the top
menu, and go to :menuselection:`Settings app --> Accounting --> Fiscal Localization`.
User :doc:`access </applications/general/users/access_rights>` can be restricted or granted to
specific companies, including parent companies and branches, to limit visibility to records
associated only with the companies users are authorized to access. As a result, records such as
purchase orders, projects, and invoices are displayed based on the user’s profile and access rights.

For example, certain users can be restricted to a specific shop, while an administrator with access
to the parent company can manage all related shops and branches.

To do so, open the Settings app, navigate to the :guilabel:`Users` section, and click
:guilabel:`Manage Users`. Open the user form and add or remove companies in the :guilabel:`Allowed
Companies` field.

.. tip::
Alternatively, access can be set in :menuselection:`Settings --> Users & Companies -->
Users`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would rework this section to simplify it a bit, focus on what is specific to branches vs a "standard" multi-company environment and make sure to explain (more clearly) how it works with the parent company vs a branch vs an individual ("standalone") company, maybe? I would also link to the relevant docs (users & access rights). I don't think the instructions are entirely necessary as they are thoroughly mentionned in the other docs I mentionned and not specific to branches?

Comment on lines +188 to +200
Consolidated or branch view
---------------------------

Focusing on the parent company allows automatic connection to all related branches, providing a
consolidated activity view across the entire database.

Each branch operates in its own environment, where activities such as accounting, HR, inventory
management, and production can be managed independently. By restricting user access, each branch can
function like a standalone company.

Except for :ref:`accounting <accounting/branch-management>` settings, inherited from the parent
company, other configurations must be created or adjusted individually in each branch. This allows
for branch-specific setups such as loyalty programs, price lists, or inventory locations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty general to how branches "work", so I’d suggest moving this section above the other two and possibly turning the other two sub-sections into H4s (i.e. sub-sections of this section). I would also rethink the title and rewrite the section a bit to make it more “instructions-style”. We can discuss this if you'd like!

@afma-odoo afma-odoo changed the title [NEW] accounting: adding new branch management information [IMP] accounting: (multi) companies, branches & accountant access info May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants