Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #639.
Here's the current state of this: we need to manually convert NamedTuples to regular tuples. I tested this functionality with our current web3.py and it works properly, but it means we can not use higher level APIs such as nested tuples, tuple lists and named tuples without converting them manually.
Testing with my changes in the web3.py, we can safely remove the forced conversions, which are now marked with a TODO.
My plan is to standardise all tuple sending inside ocean.py after this fix is merged into web3.py. This way, we can allow users to use regular tuples, dictionaries etc. but we can also standardise and reuse NamedTuple structures throughout our application. E.g. provider fees, ERC20 create data, Pool data, FRE data, OrderData etc. Right now, the structures are all over the place e.g.:
Should we create a separate issue for this? While it is true that this PR fixes a blocker, I would like to add this tuple standardisation into ocean.py since it will greatly benefit us and our users.