Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Document "import" warning in Unified module #412

Merged
5 commits merged into from
Jun 10, 2021
Merged

Document "import" warning in Unified module #412

5 commits merged into from
Jun 10, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 9, 2021

Issue: ocaml/ocaml.org#298 (comment)

Done:

  • Add more documentation around the warning that was introduced by implementing a workaround for referencing a pure ESM library from the NextJS commonjs context

@ghost ghost added the polishing-draft-PR label Jun 9, 2021
@vercel
Copy link

vercel bot commented Jun 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ocaml/v3-ocaml-org/EKL638w4rpD5yBNMUehi4f1SwY4Z
✅ Preview: https://v3-ocaml-org-git-kw1-fix-raw-warning-ocaml.vercel.app

@ghost
Copy link
Author

ghost commented Jun 9, 2021

We decided to change this PR add more comments near the offending code. I will rework the PR soon.

@ghost ghost changed the title Suppress "import" warning in Unified module Document "import" warning in Unified module Jun 10, 2021
@ghost ghost merged commit 08689fc into master Jun 10, 2021
@ghost ghost deleted the kw1/fix-raw-warning branch June 10, 2021 19:58
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants