Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Generate markdown TOC #296

Merged
26 commits merged into from
Apr 22, 2021
Merged

Generate markdown TOC #296

26 commits merged into from
Apr 22, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2021

#243 . This PR evolved from a spike into implementation.

@vercel
Copy link

vercel bot commented Apr 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/solvuu/nextocamlorg/7pnVgB54rHNT7smDfa3hBQM6LnWA
✅ Preview: https://nextocamlorg-git-kw1-generate-toc-spike-solvuu.vercel.app

@ghost
Copy link
Author

ghost commented Apr 21, 2021

I encountered a blocking issue where the es6 and commonjs module systems were clashing. It was unclear what was forcing commonjs. I wasn't able to understand the root cause. It might take some time to understand it.

I implemented a workaround where I implemented my own functionality instead of using the library that was having difficulties. It's working so far, but may encounter issues when trying to use other libraries that are necessary.

  • Create a follow-up issue after this PR to investigate why commonjs and es6 were clashing when using unist-util-visit

The new issue is #298 .

@ghost ghost changed the title Spike: Generate markdown TOC Generate markdown TOC Apr 21, 2021
… Error: Can't resolve 'common/App.js' in '/vercel/workpath0/pages'"
@ghost
Copy link
Author

ghost commented Apr 21, 2021

I am purely refactoring and cleaning up code from this point onwards. The essentials are all in place.

@ghost ghost marked this pull request as ready for review April 21, 2021 23:56
@ghost ghost merged commit 58d78a4 into master Apr 22, 2021
@ghost ghost deleted the kw1/generate-toc-spike branch April 22, 2021 00:00
@ghost ghost mentioned this pull request Apr 22, 2021
5 tasks
@ghost ghost added the review-after-merging label Apr 22, 2021
@ghost ghost mentioned this pull request May 5, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants