year and integer type scales #1268
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For axes, we also need to pass the following elements, which are not exposed by _plot_.scale("x"):
- the scale's label
- the underlying D3 scale’s tickFormat and tick functions
- the range of the identity scale
…his cleans up the API
Fil
changed the title
Fil
force-pushed
the
fil/year-tickFormat
branch
from
b13f8b9 to
a8a7ccc
Compare
mbostock
reviewed
Mar 15, 2023
There was a problem hiding this comment.
What if we did this by introducing a new year scale type? Then we could change the inferScaleType function to choose year over linear if the data matches. We already have a bunch of inference in inferScaleType (rather than mixing inference into Scales), and using a new scale type gives an explicit way for the user to opt-in or opt-out of this behavior.
I guess we’d need year-point and year-band for the ordinal case? Or maybe a separate year option? I dunno. I’ll need to think about that one.
|
Can we do this without coupling it to #1265? I’m looking for smaller wins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an integer flag on a scale when the associated channels are all integers, either because the interval option is integer, or because we checked a sample of 40 values in each channel.
This flag cannot be specified by the user (but they can use interval: 1), and is censored when the scale is exported.
When the axis text mark decides on its tickFormat, the heuristic is that if the scale is integer and the domain is covered by [1500...2200], it's probably best to default to "d" rather than formatDefault (for ordinal scales) or the linear scale’s default number format, since it's possible that the values are years.
Closes #768
(This is built on top of #1265 but the same logic could be built on the scale function.)
Related: #932