Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With async/await on the linux repo:
get_git_history
is overwhelmingly slower than the other functions;even with async/await the execution is still very synchronous-like.time onefetch ../linux real 0m22,442s user 0m48,883s sys 0m6,863s
Without async/await on the linux repo:
time onefetch ../linux real 0m15,631s user 0m22,745s sys 0m4,017s
It may have been a false good idea to add tokio runtime - with its huge added complexity - to onefetch. Especially considering the use case - only one very slow function
get_git_history
-. Without async/await, onefetch appears to compile and run faster and use less cpu resources (cf.user
time).