Skip to content

Code redundancy #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nylonee opened this issue Dec 21, 2016 · 0 comments
Open

Code redundancy #4

nylonee opened this issue Dec 21, 2016 · 0 comments
Assignees
@nylonee
Labels
enhancement

Comments

@nylonee
Copy link
Owner

nylonee commented Dec 21, 2016

A lot of the code is redundant, especially between lightmapped and non-lightmapped functions.

The defines can also be improved, especially where they depend on each other, eg the NORMAL_ON define won't work without PHONG_ON defined.
@nylonee nylonee self-assigned this Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nylonee nylonee

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nylonee