fix(#2243): fs_watcher not started for .git folders (Win) #2265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue described in nvim-tree#2243, where the .git folder's path ends on a weird character produced by `cygpath` when the newline character is fed into it (when using shell=powershell)
alex-courtis
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Thank you for your contribution.
This is behind the windows feature flags and will only affect a small number of users.
I cannot review or test this one; I assume it is working for you.
Please be prepared to resolve any issues that may arise from this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2243
The fix happens inside a
if vim.fn.has "win32"block and thus, does not affect WSL.If necessary, I could install cygwin to test it on that too. Also, I wasn't sure, what test case (in CONTRIBUTING.md) meant, as I didnt find a test setup for the repo. The issue describes the exact problematic case and why this fix works for it. If more description is needed, please tell me :)