fix(#1815): don't schedule find file calls

[alex-courtis]

fixes #1815

Optimistic PR for dogfooding.

Both
https://github.com/nvim-tree/nvim-tree.lua/pull/1820/files#diff-d2d7203cea884a09928ac1574693d436d6e3db28e62daabfa53f5f9f7740f51aR157 and

nvim-tree.lua/lua/nvim-tree/actions/finders/find-file.lua

Line 21 in b17358f

local fname_real = vim.loop.fs_realpath(fname)

protect against any finding of buffers that are not real files i.e. not nvim-tree itself.

[gegoune]

Functionally it works, thanks for the fix!

But not exporting find_file() will break for users using it. I am not sure if it ever was meant to be used and given we have an api we should make it the only 'entry' point to nvim-tree (programatically).

Should equivalent be:

      require('nvim-tree').open()
      require('nvim-tree.api').tree.find_file(bufname)

?

[alex-courtis]

But not exporting find_file() will break for users using it. I am not sure if it ever was meant to be used and given we have an api we should make it the only 'entry' point to nvim-tree (programatically).

Ah of course, I wondered why it was public.

There's api.tree.find_file, api.tree.toggle, :NvimTreeFindFile and :NvimTreeFindFileToggle

I'm game to remove it if you are ;)

[alex-courtis]

Quick BufEnter events cause multiple find_file calls, which is a performance hit as it results in an FS and git refresh.

Debounced all events with single context "BufEnter:find_file".

[gegoune]

Absolutely, remove it. Even if it was not intended to be used I think that removal warrants notifying users? It will be breaking change for sure.

[alex-courtis]

Even if it was not intended to be used I think that removal warrants notifying users?

a284061