fix(#1731 #1723 #1716): handle all external file system changes #1757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g absolute path, profile refresh
This reverts commit 5dfd8bd.
alex-courtis
changed the title
alex-courtis
changed the title
|
I would be very grateful for a review and real world test over a few days. This one has been tricky... |
gegoune
approved these changes
Nov 20, 2022
Thank you.
Edit: added fix for #1716 in the interests of testing simplicity
|
alex-courtis
commented
Nov 20, 2022
| else | ||
| log.line("watcher", "node event executing refresh '%s'", node.absolute_path) | ||
| end | ||
| require("nvim-tree.explorer.reload").refresh_node(node) |
There was a problem hiding this comment.
This will still result in one refresh for each instance of the symlinked dir, however optimising that away requires significant complexity.
alex-courtis
changed the title
|
Pulling the trigger. Thanks for testing @gegoune This has been a difficult fix. If there are issues I plan to push forward with fixes rather than reverting again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1731 #1723 #1716
Link directory nodes are the main issue here.
Outstanding, follow up PR: