-
-
Notifications
You must be signed in to change notification settings - Fork 627
chore: remove pngs from .github folder and use direct links for imgs in README.md #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove pngs from .github folder and use direct links for imgs in README.md #1642
Conversation
Please don't commit images to repository. Media files should be added to an issue and linked from there to avoid users having to download those files while installing plugin. |
Yes you are right, I added it in .github to follow the other screenshots' location, I think we should move them all |
I'll remove the pngs from .github folder and upload them here to this PR, and use their links in the README.md |
Thank you very much @Almo7aya. I have envisioned new issue called Maybe craete new issue with only existing images in it, then add new comment with your new images and update that pr accordingly? |
or a wiki page |
That's probably even better. |
I created a wiki page https://github.com/nvim-tree/nvim-tree.lua/wiki/Showcases with all the pngs in the .github folder, newly added screenshots should be uploaded there and use their links in the README.md file if we are planning to keep them there |
Thanks @Almo7aya We should just link that wiki page at the bottom of the readme. |
Can you please add a link you your setup lua source @Almo7aya ? Others will likely want to clone bits of it. I've done that with a link to the specific commit for my |
@alex-courtis I'm using https://github.com/lunarvim/lunarvim/ so my config is tied to their implementation, I'll create a standalone config for it and add it to the wiki page |
Uh oh!
There was an error while loading. Please reload this page.