Skip to content

chore: remove pngs from .github folder and use direct links for imgs in README.md #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Almo7aya
Copy link
Contributor

@Almo7aya Almo7aya commented Oct 11, 2022

  • added a screenshot for nvim-tree in floating window mode

@gegoune
Copy link
Collaborator

gegoune commented Oct 11, 2022

Please don't commit images to repository. Media files should be added to an issue and linked from there to avoid users having to download those files while installing plugin.

@Almo7aya
Copy link
Contributor Author

Almo7aya commented Oct 11, 2022

Please don't commit images to repository. Media files should be added to an issue and linked from there to avoid users having to download those files while installing plugin.

Yes you are right, I added it in .github to follow the other screenshots' location, I think we should move them all

@Almo7aya
Copy link
Contributor Author

I'll remove the pngs from .github folder and upload them here to this PR, and use their links in the README.md

@Almo7aya
Copy link
Contributor Author

Almo7aya commented Oct 11, 2022

Screenshots

example help
example tree
screenshot-alex-courtis
screenshot
screenshot2
screenshot3
screenshot4
screenshot-almo7aya

@Almo7aya Almo7aya changed the title chore: add a screenshot to demo tree on floating window chore: remove pngs from .github folder and use direct links for imgs in README.md Oct 11, 2022
@gegoune
Copy link
Collaborator

gegoune commented Oct 12, 2022

Thank you very much @Almo7aya. I have envisioned new issue called Showcase where users could upload their screenshots, we could update readme links if something beautiful comes up. Would you mind recreating your last post here as a new issue? GitHub does not allow us to create new issue of comment, just to reference it.

Maybe craete new issue with only existing images in it, then add new comment with your new images and update that pr accordingly?

@kyazdani42
Copy link
Member

or a wiki page

@gegoune
Copy link
Collaborator

gegoune commented Oct 12, 2022

That's probably even better.

@Almo7aya
Copy link
Contributor Author

I created a wiki page https://github.com/nvim-tree/nvim-tree.lua/wiki/Showcases with all the pngs in the .github folder, newly added screenshots should be uploaded there and use their links in the README.md file if we are planning to keep them there

@kyazdani42 kyazdani42 merged commit b07701f into nvim-tree:master Oct 13, 2022
@alex-courtis
Copy link
Member

Thanks @Almo7aya

We should just link that wiki page at the bottom of the readme.

@alex-courtis
Copy link
Member

I created a wiki page https://github.com/nvim-tree/nvim-tree.lua/wiki/Showcases with all the pngs in the .github folder, newly added screenshots should be uploaded there and use their links in the README.md file if we are planning to keep them there

Can you please add a link you your setup lua source @Almo7aya ? Others will likely want to clone bits of it.

I've done that with a link to the specific commit for my nvim-tree.lua above the image.

@Almo7aya
Copy link
Contributor Author

@alex-courtis I'm using https://github.com/lunarvim/lunarvim/ so my config is tied to their implementation, I'll create a standalone config for it and add it to the wiki page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants