feat(watcher): debounce FS watchers #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
changed the base branch from
master
to
feat/optimise-watchers-1-partial-git-refresh
alex-courtis
commented
Jun 26, 2022
alex-courtis
commented
Jun 26, 2022
kyazdani42
reviewed
Jun 26, 2022
…heck, clarify debounce doc
…r node event logging
alex-courtis
commented
Jun 27, 2022
alex-courtis
commented
Jun 27, 2022
kyazdani42
approved these changes
Jun 27, 2022
|
Whoops... merged to feat/optimise-watchers-1-partial-git-refresh Manually rebased / merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #1373
Not very useful until we move to fs_event as fs_poll is aready throttled.
I have played around a few options but was not happy:
Debounce refreshes by absolute path seems the best option.
Having multiple refresh events running for different paths is OK, as we are only looking at the FS and git for that path.