Very slow on exit neovim

[overcache]

Description

I've noticed that when I exit Neovim, it's extremely slow, often hanging on the :qa command for 5 seconds or even longer before the Neovim instance finally quits. After individually removing plugins, I eventually identified that nvim-tree was the cause of this issue.

Neovim version

NVIM v0.9.2
Build type: Release
LuaJIT 2.1.0-beta3

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/0.9.2/share/nvim"

Run :checkhealth for more info

Operating system and version

macOS12.1, Darwin macbox.local 21.2.0 Darwin Kernel Version 21.2.0: Sun Nov 28 20:28:54 PST 2021; root:xnu-8019.61.5~1/RELEASE_X86_64 x86_64

nvim-tree version

934469b

Clean room replication

vim.g.loaded_netrw = 1
vim.g.loaded_netrwPlugin = 1

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvt-min/site]]
local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup {
    {
      "wbthomason/packer.nvim",
      "nvim-tree/nvim-tree.lua",
      "nvim-tree/nvim-web-devicons",
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  }
end
if vim.fn.isdirectory(install_path) == 0 then
  print "Installing nvim-tree and dependencies."
  vim.fn.system { "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path }
end
load_plugins()
require("packer").sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]]
vim.opt.termguicolors = true
vim.opt.cursorline = true

-- MODIFY NVIM-TREE SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
_G.setup = function()
  require("nvim-tree").setup {
        -- copy form 'ahmedkhalf/project.nvim'
      sync_root_with_cwd = true,
      respect_buf_cwd = true,
      update_focused_file = {
        enable = true,
        -- update_root = true
      },
      --

      disable_netrw = true,
      view = { number = false, },
      git = { ignore = false },
      renderer = {
        add_trailing = true,
      },
      }
end

Steps to reproduce

0. cd to some Project: cd webpack
1. nvim -nu /tmp/nvt-min.lua
2. open some file: :e package.json
3. :NvimTreeFindFile
4. open some file in deep dir: :e node_modules/semver/bin/semver.js
5. quit: :qa, neovim will hang 3~5 seconds

Expected behavior

:qa execute then neovim quit quickly.

Actual behavior

quit: :qa, neovim will hang 3~5 seconds

[gegoune]

I can't replicate it (in sense that I have never experienced that before). Is the delay present without any open buffers as well?

[overcache]

I can't replicate it (in sense that I have never experienced that before). Is the delay present without any open buffers as well?

when I delete all buffer manually before exit, the issuse still present.
Did you use the 'webpack' project? When I open files in node_modules, the issuse occur. Open other files which not in node_modules, thats fine.

[overcache]

iShot_2023-10-01_19.54.12.mp4

[alex-courtis]

Tried unsuccessfully with minimal config and linux source:
:e COPYING
:NvimTreeFindFile
:e tools/testing/selftests/rcutorture/formal/srcu-cbmc/include/linux/types.h

Your video shows that you are using plugins other than specified in the minimal config. Please reproduce with the minimal config as instructed: "Clean Room" Replication

Please enable Diagnostic Logging after reproducing with git profile and watcher.

[overcache]

There is no other plugins, the top line of video was the tmux panel list.

I tried to reproduce on a fresh linux virtual machine this morning but failed. It seems that I can only replay the issue on my iMac.

After delete some nvim-tree setting, the necessary settting are:

  require("nvim-tree").setup {
      update_focused_file = {
        enable = true,
      },
      git = { ignore = false },
   }

Either set update_focused_file.enable = false or git.ignore = true get rid of the "hang on :qa" problem.
I can't find out what environment effect nvim-tree works, any advice?

Here is another video:

iShot_2023-10-02_12.22.42.mp4

[alex-courtis]

Is the iMac old / slow? Was the VM on that iMac?

It seems the issue could be:

1. slow git processing (unlikely, as it's mostly async)
2. slow FS enumeration

Diagnostic Logging will shed some light on this.

[alex-courtis]

Unrelated, however you can get some significant OSX git performance gains Git fsmonitor Daemon

[overcache]

My computer is a 2017 iMac. It's a bit old, but not that old.
I just logged into the guest account and was able to reproduce the issue. I'll try it on my M1 MacBook at home tonight.

[overcache]

I can reproduce on M1 Macbook air(macOS 12.6.5 ) too.

[alex-courtis]

Without logs or being able to reproduce there's no path forward here.

@gegoune could you attempt a replication?

[GZLiew]

I can reproduce this and neovim just hangs after I did a npm install on the project
I think nvim-tree is trying to read updates in node_modules folder which causes the hang