[Followup] Missing steps for stable filesystem watchers

[kyazdani42]

To implement

• implement watcher for symlinked directories
• cleanup watchers whenever directories are removed / renamed
• [ ] more .git watchers (optional, might not be needed)
• handle concurrent git jobs
• replace fs_poll with something more efficient and targeted
• abandon git update on invalid path feat(watcher): partial git refresh #1373 (comment)
• resolve debouncer concurrency issues: [coc.nvim] Error on request (diagnosticList) #1317 (comment)

Issues

Linux

Macos

Windows

[alex-courtis]

See #1317 for similar issue RE concurrest LSP jobs. A generic solution may be used for git, coc and lsp.

[alex-courtis]

This repo (with submodules populated) is good for stress testing: https://github.com/qmk/qmk_firmware/

[kyazdani42]

@alex-courtis i'm not sure i understand the last comment, did you maybe comment on the wrong issue :) ?

[alex-courtis]

I'm using that qmk repo to test git watcher concurrency: modify a few files in differect directories then git checkout. That takes a long time.

[kyazdani42]

I'd like to see how a firmware can be used to do that ! Do you have a sample repository ?

[gegoune]

@kyazdani42 I think what @alex-courtis is saying is that qmk repo is his test repository. :)

[kyazdani42]

😄 oh now i understand !

[alex-courtis]

Drafted some ideas around concurrency: #1343

[alex-courtis]

implement watcher for symlinked directories

This is working now:

• symlinked directories are watched, via a watcher on the target
• works for symlinks inside the tree and outside
• newly created and destroyed links have their watchers created / destroyed

To do:

1. too many watchers new'd for the target directory, resulting in Watcher:new using existing
   a. previus watcher is clobbered, destroying its callbacks
   a. link remove destroys the watcher for the target directory

#1453