Skip to content

fix(mappings): use explicit bufnr for meta return in apply_text_edits #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PriceHiller
Copy link
Contributor

Copied from the commit message:

Since neovim/neovim@2e1f505, Neovim now explicitly requires the bufnr for vim.lsp.util.apply_text_edits to be fully resolved — meaning it cannot be 0 or null.

This just ensures nightly users don't run into errors when using meta return and that the tests for nightly pass as expected.

Since
neovim/neovim@2e1f505,
Neovim now explicitly requires the bufnr for
`vim.lsp.util.apply_text_edits` to be fully resolved — meaning it cannot
be 0 or null.
Copy link
Member

@kristijanhusak kristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@kristijanhusak kristijanhusak merged commit 32388f9 into nvim-orgmode:master Feb 25, 2024
@PriceHiller PriceHiller deleted the fix/provide-explicit-bufnr-nightly branch February 25, 2024 07:35
SlayerOfTheBad pushed a commit to SlayerOfTheBad/orgmode that referenced this pull request Aug 16, 2024
…s` (nvim-orgmode#684)

Since
neovim/neovim@2e1f505,
Neovim now explicitly requires the bufnr for
`vim.lsp.util.apply_text_edits` to be fully resolved — meaning it cannot
be 0 or null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants