fix(cron): Handle errors in cron and send system notification about error

Author: kristijanhusak

lua/orgmode/files/headline.lua

@@ -304,7 +304,8 @@ function Headline:get_todo()
   local keywords_info = todo_keywords.KEYS
 
   -- A valid keyword can only be the first child
-  local todo_node = self:_get_child_node('item'):named_child(0)
+  local first_item_node = self:_get_child_node('item')
+  local todo_node = first_item_node and first_item_node:named_child(0)
   if not todo_node then
     return nil, nil, nil
   end

lua/orgmode/init.lua

@@ -208,18 +208,23 @@ function Org.action(cmd, opts)
 end
 
 function Org.cron(opts)
-  local config = require('orgmode.config'):extend(opts or {})
-  if not config.notifications.cron_enabled then
-    return vim.cmd([[qa!]])
-  end
-  Org.files:load():next(vim.schedule_wrap(function()
-    ---@diagnostic disable-next-line: inject-field
+  local ok, result = pcall(function()
+    local config = require('orgmode.config'):extend(opts or {})
+    if not config.notifications.cron_enabled then
+      return vim.cmd([[qa!]])
+    end
+    Org.files:load_sync(true, 20000)
     instance.notifications = require('orgmode.notifications')
       :new({
         files = Org.files,
       })
       :cron()
-  end))
+  end)
+
+  if not ok then
+    require('orgmode.utils').system_notification('Orgmode failed to run cron: ' .. tostring(result))
+    return vim.cmd([[qa!]])
+  end
 end
 
 function Org.instance()

lua/orgmode/utils/init.lua

@@ -79,6 +79,16 @@ function utils.writefile(file, data)
   end)
 end
 
+function utils.system_notification(message)
+  if vim.fn.executable('notify-send') == 1 then
+    vim.loop.spawn('notify-send', { args = { message } })
+  end
+
+  if vim.fn.executable('terminal-notifier') == 1 then
+    vim.loop.spawn('terminal-notifier', { args = { '-message', message } })
+  end
+end
+
 function utils.open(target)
   if vim.fn.executable('xdg-open') == 1 then
     return vim.fn.system(string.format('xdg-open %s', target))

lua/orgmode/utils/promise.lua

@@ -264,18 +264,31 @@ end
 --- @return any
 function Promise.wait(self, timeout)
   local is_done = false
+  local has_error = false
   local result = nil
 
-  self:next(function(...)
-    result = PackedValue.new(...)
-    is_done = true
-  end)
+  self
+    :next(function(...)
+      result = PackedValue.new(...)
+      is_done = true
+    end)
+    :catch(function(...)
+      has_error = true
+      result = PackedValue.new(...)
+      is_done = true
+    end)
 
   vim.wait(timeout or 5000, function()
     return is_done
   end, 1)
 
-  return result and result:unpack()
+  local value = result and result:unpack()
+
+  if has_error then
+    return error(value)
+  end
+
+  return value
 end
 
 --- Equivalents to JavaScript's Promise.all.