Change how test-cli is running

The cli-test is in the tests directory. It is a separate go module,
because we don't want it to run with the unit tests when running

go test ./...

But this approach causes issues with automatic update of dependencies,
because the go.mod in the tests directory does not get automatic
updates, and then fauls in CI.

Instead, this commit changes the cli-test to only run if the RUN_CLI_TESTS
environment variable is set to "true".

In addition, this commit stopped using the deprecated testscript.RunMain
function, and replaces it with the recommended testscript.Main function.

Author: nunnatsa

Makefile

@@ -24,7 +24,7 @@ build-for-linux:
 build-all: build build-for-linux build-for-mac build-for-windows
 
 test-cli:
-	cd tests; go test -v ./
+	RUN_CLI_TESTS=true go test -v ./tests/...
 
 test: unit-test test-cli
 

cmd/ginkgolinter/cli/cli.go

@@ -11,7 +11,7 @@ import (
 	"github.com/nunnatsa/ginkgolinter/version"
 )
 
-func Main() int {
+func Main() {
 	if len(os.Args) == 2 && os.Args[1] == "version" {
 		fmt.Printf("ginkgolinter version: %s\n", version.Version())
 		fmt.Printf("git hash:             %s\n", version.GitHash())
@@ -20,6 +20,4 @@ func Main() int {
 	}
 
 	singlechecker.Main(ginkgolinter.NewAnalyzer())
-
-	return 0
 }

tests/cli_test.go

@@ -21,12 +21,16 @@ func TestMain(m *testing.M) {
 		panic(err)
 	}
 
-	os.Exit(testscript.RunMain(m, map[string]func() int{
+	testscript.Main(m, map[string]func(){
 		"ginkgolinter": cli.Main,
-	}))
+	})
 }
 
 func TestCli(t *testing.T) {
+	if os.Getenv("RUN_CLI_TESTS") != "true" {
+		t.Skipf(`Skipping CLI tests. These tests are not unit tests, but more like integration tests.
+The tests will run when the RUN_CLI_TESTS environment variable is set to "true"`)
+	}
 	pwd, err := os.Getwd()
 	if err != nil {
 		panic(err)