Skip to content

Update pydata-sphinx-theme #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

jarrodmillman
Copy link
Member

Use more recent sphinx and pydata-sphinx-theme to build documentation.

I also bumped circleci to use Python 3.11 to build the docs.

'pydata-sphinx-theme>=0.13',
'sphinx>=6',
'pydata-sphinx-theme>=0.13.3',
'sphinx>=7',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might need a <7.2 until pydata-sphinx-theme releases a new version, see pydata/pydata-sphinx-theme#1404 (which could have at one point read "incompatibility with Sphinx 7.2")... but they just cut 7.2.1 so we'll see!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.2.1 worked for me on my computer...

Copy link
Collaborator

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking for merge-when-green, hopefully it works

@larsoner
Copy link
Collaborator

we should also get rid of the style run, it should be redundant with pre-commit.ci now. Feel free to do it here if you want @jarrodmillman, I'm adding a branch protection rule so we can click "merge when green" in the future

@larsoner larsoner merged commit a451328 into numpy:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants