Skip to content

MAINT: Compatibility with pydata-sphinx-theme #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 3, 2023
Merged

Conversation

larsoner
Copy link
Collaborator

@larsoner larsoner commented Mar 3, 2023

Will self-merge if this comes back green and looks okay

@larsoner
Copy link
Collaborator Author

larsoner commented Mar 3, 2023

Okay I won't self-merge this one since it ended up being a bit more comprehensive:

  1. Fix compat bug with latest pydata-sphinx-theme by using newer icon_links
  2. Remove old compat code in our doc/conf.py for pydata-sphinx-theme <9 since we require >=0.11 in our requirements already
  3. Add CI runs for Sphinx ==6.0 and >6.0 since pydata-sphinx-theme now supports it

Ready for review/merge from my end, maybe @rossbar ?

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @larsoner !

@rossbar rossbar merged commit 9c59a46 into numpy:main Mar 3, 2023
@larsoner larsoner deleted the pst branch March 3, 2023 18:32
@jarrodmillman jarrodmillman added this to the 1.6.0 milestone Mar 14, 2023
guillaumedavidphd added a commit to guillaumedavidphd/numpydoc that referenced this pull request Apr 7, 2023
* MAINT: Fix CIs for sphinx 6 (numpy#448)

* BUG: PR06 logic to only fail when type is used standalone (numpy#447)

Change PR06 logic to only fail when type is used standalone.

This prevents failures for user-defined classes, e.g. Mystring

Co-authored-by: Ross Barnowski <[email protected]>

* Update pre-commit (numpy#449)

* Update pre-commit

* Run pre-commit on all files

* Update blacken-docs repo in pre-commit conf after owner transfer. (numpy#451)

* MAINT: Compatibility with pydata-sphinx-theme (numpy#453)

Fix compatibility issues between latest pydata-sphinx-theme and sphinx 6.

Increase granularity of CI to test across necessary sphinx & Python version combos.

* MAINT: Refactoring `get_doc_object` (numpy#452)

---------

Co-authored-by: Eric Larson <[email protected]>
Co-authored-by: Bryce Mecum <[email protected]>
Co-authored-by: Ross Barnowski <[email protected]>
Co-authored-by: Jarrod Millman <[email protected]>
Co-authored-by: Stefanie Molin <[email protected]>
Co-authored-by: yuki <[email protected]>
guillaumedavidphd added a commit to guillaumedavidphd/numpydoc that referenced this pull request Apr 18, 2023
* MAINT: Fix CIs for sphinx 6 (numpy#448)

* BUG: PR06 logic to only fail when type is used standalone (numpy#447)

Change PR06 logic to only fail when type is used standalone.

This prevents failures for user-defined classes, e.g. Mystring

Co-authored-by: Ross Barnowski <[email protected]>

* Update pre-commit (numpy#449)

* Update pre-commit

* Run pre-commit on all files

* Update blacken-docs repo in pre-commit conf after owner transfer. (numpy#451)

* MAINT: Compatibility with pydata-sphinx-theme (numpy#453)

Fix compatibility issues between latest pydata-sphinx-theme and sphinx 6.

Increase granularity of CI to test across necessary sphinx & Python version combos.

* MAINT: Refactoring `get_doc_object` (numpy#452)

---------

Co-authored-by: Eric Larson <[email protected]>
Co-authored-by: Bryce Mecum <[email protected]>
Co-authored-by: Ross Barnowski <[email protected]>
Co-authored-by: Jarrod Millman <[email protected]>
Co-authored-by: Stefanie Molin <[email protected]>
Co-authored-by: yuki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants