Skip to content

Use isgeneratorfunction to avoid false alarm YD01 validation #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2022
Merged

Use isgeneratorfunction to avoid false alarm YD01 validation #368

merged 1 commit into from
Mar 15, 2022

Conversation

jnothman
Copy link
Member

Fixes #365

Could do with a test

@larsoner
Copy link
Collaborator

Could do with a test

@jnothman up to you if you want to add one here, seems like a pretty clear bugfix to me!

@jnothman
Copy link
Member Author

In the context, let's merge

@jnothman jnothman merged commit 9b7ada8 into main Mar 15, 2022
@jarrodmillman jarrodmillman added this to the 1.2.1 milestone Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrodmillman jarrodmillman jarrodmillman approved these changes

Assignees
No one assigned
Labels
type: Bug fix
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

Validation check YD01 not implemented properly
3 participants
@jnothman @larsoner @jarrodmillman