Skip to content

BUG: fix role regex. #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2020
Merged

BUG: fix role regex. #280

merged 1 commit into from
Jul 13, 2020

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Jul 13, 2020

Spyder sometime uses the full :py:meth: role, this make sure it is
properly handled.

Spyder sometime uses the full :py:meth: role, this make sure it is
properly handled.
@codecov-commenter
Copy link

Codecov Report

Merging #280 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   93.15%   93.23%   +0.07%     
==========================================
  Files           7        7              
  Lines        1257     1257              
==========================================
+ Hits         1171     1172       +1     
+ Misses         86       85       -1     

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Carreau.

The tests don't actually need access to the intersphinx inventory here to pass, so using the actual objects that were problematic seems fine to me.

@larsoner larsoner merged commit a82926f into numpy:master Jul 13, 2020
@larsoner
Copy link
Collaborator

Thanks @Carreau

@jarrodmillman jarrodmillman added this to the 1.2.0 milestone Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants