Skip to content

Add missing headings to code examples #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Conversation

Cadair
Copy link
Contributor

@Cadair Cadair commented Jan 29, 2020

The Notes and Examples sections have code examples showing what can go in the section, and unlike all the other sections with examples didn't show the heading.

This lead to some confusion when reading the notes section between that and .. note:

The Notes and Examples sections have code examples showing what can go in the section, and unlike all the other sections with examples didn't show the heading.
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

@larsoner larsoner merged commit 5e9a629 into numpy:master Jan 31, 2020
@larsoner
Copy link
Collaborator

Thanks @Cadair

@Cadair Cadair deleted the patch-1 branch January 31, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants